Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creality_ender3.def.json #5456

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Update creality_ender3.def.json #5456

merged 2 commits into from
Mar 21, 2019

Conversation

drzejkopf
Copy link
Contributor

Changed override of "default_value" to "value" of acceleration_travel and jerk_travel to make slicer keep those values, as they were overrided by conditional in fdmprinter.def.json, and also removed layer height as it does nothing because it's overriden by preffered quality (draft) settings

Changed override of "default_value" to "value" of acceleration_travel and jerk_travel to make slicer keep those values, as they were overrided by conditional in fdmprinter.def.json, and also removed layer height as it does nothing because it's overriden by preffered quality (draft) settings
@Ghostkeeper
Copy link
Collaborator

For "value" it needs to be a string, right? The value is then a Python expression.

@drzejkopf
Copy link
Contributor Author

drzejkopf commented Mar 20, 2019

@Ghostkeeper I have checked it and it works well on my computer, but on second thoughts I think that it would be better to change it to:

"acceleration_travel": {
   "value": "acceleration_print"
}
"jerk_travel": {
   "value": "jerk_print"
}

but I have no idea how to edit file in pull request
Edit: Ok, I figured it out and changed those values

@Ghostkeeper Ghostkeeper merged commit f03e5c2 into Ultimaker:master Mar 21, 2019
@Ghostkeeper
Copy link
Collaborator

Thanks. Looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants