Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freezing on SKR-E3-mini-v1.2 board #7078

Closed
wants to merge 1 commit into from
Closed

Fix freezing on SKR-E3-mini-v1.2 board #7078

wants to merge 1 commit into from

Commits on Feb 9, 2020

  1. Fix freezing on SKR-E3-mini-v1.2 board

    When attached to a BigTreeTech SKR-E3-mini-v1.2 board, Cura+USB seems to reliably hang the printer; sometimes you'll hear an alarm sound, other times the printer will just freeze entirely.
    
    The leaveISP() function claims that the serial port is still valid, but as far as I can tell this isn't an actually-valid assumption; it was first introduced in b4df277 but I can't quite track context behind that. This might be true for a bunch of devices but I doubt it's true generally.
    
    My hypothesis here is that leaveISP causes the STM32F103RCT6 to reboot, which then wigs out the power-selector circuit (there's now USB power where there wasn't before), and now all of a sudden the chip is in an entirely different state. But that's mostly a guess.
    
    It doesn't look like the programmer is necessary, however; it simply connects, loads a register for a READ/WRITE command to use, checks the availability of a checksum byte, and then returns. Since we don't care for that, we can just open individual serial connections as/when they're needed with the various different baud rates. This stops my personal SKR-E3-mini-v.2 board from failing, and since this looks like the same fix as https://www.reddit.com/r/BIGTREETECH/comments/dp6k6r/skr_mini_e3_v12_and_curausb/fbv808j/ I'm going to guess that it works for everyone.
    
    I suspect this also fixes issue #6531.
    bgbnbigben authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    fd9377c View commit details
    Browse the repository at this point in the history