Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-11102] qml warnings #913

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[CURA-11102] qml warnings #913

merged 2 commits into from
Oct 10, 2023

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Oct 9, 2023

  • The first mentioned QML warning has been fixed already with commit 1f67452
  • Fixed two other QML binding loop warnings.
    • The one in Menu.qml implies that the width of the menu will not automatically change if any of the menu item changes. It will be updated only when the menu is opened again. In practice, this does not happen because it would be very user-unfriendly to have a menu that changes its width while the mouse cursor is over it.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Unit Test Results

2 406 tests  +2 406   2 391 ✔️ +2 391   25s ⏱️ +25s
       1 suites +       1        15 💤 +     15 
       1 files   +       1          0 ±       0 

Results for commit 43707f5. ± Comparison against base commit 3f20e48.

♻️ This comment has been updated with latest results.

@casperlamboo casperlamboo changed the base branch from main to 5.5 October 10, 2023 08:32
@casperlamboo casperlamboo merged commit 5ad182b into 5.5 Oct 10, 2023
13 checks passed
@casperlamboo casperlamboo deleted the CURA-11102_qml_warnings branch October 10, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants