Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulas in start/end code #914

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

casperlamboo
Copy link
Contributor

See corresponding Cura PR: Ultimaker/Cura#16962

CURA-11155

The following properties are not settings-names, but could previously be used as template variables
- material_id
- time
- date
- day
- initial_extruder_nr
- material_id
- material_name
- material_type
- material_brand
- time
- date
- day
- initial_extruder_nr
These properties are _awkwardly_ propogated through the kwargs of the `get_value` method of `GcodeStartEndFormatter`. I don't quite like implementing it like this, but to avoid API breaks I couldn't change abusing the kwargs arg for this purpose.

CURA-11155
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Unit Test Results

2 406 tests  ±0   2 391 ✔️ ±0   26s ⏱️ -5s
       1 suites ±0        15 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit eca460f. ± Comparison against base commit 66907d2.

♻️ This comment has been updated with latest results.

@saumyaj3 saumyaj3 merged commit 6745624 into main Oct 16, 2023
11 checks passed
@saumyaj3 saumyaj3 deleted the CURA-11155-formulas-in-start-end-code branch October 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants