Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of inconsistent property values #919

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

wawanbreton
Copy link
Contributor

Commit 4f32819 fixes exceptions where an empty string would be set to a floating-point property value. However, in some cases it prevents the values being intentionally set to an empty string (for properties that are actual string). This fix introduces an other way of handling this issue.

CURA-11215

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Unit Test Results

2 406 tests  ±0   2 391 ✔️ ±0   27s ⏱️ -4s
       1 suites ±0        15 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit b74edbd. ± Comparison against base commit 66907d2.

♻️ This comment has been updated with latest results.

@saumyaj3 saumyaj3 merged commit 45e7532 into 5.5 Oct 24, 2023
11 checks passed
@saumyaj3 saumyaj3 deleted the CURA-11215_Per_model_settings_broken branch October 24, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants