Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakerBot plugin #922

Merged
merged 7 commits into from
Oct 31, 2023
Merged

MakerBot plugin #922

merged 7 commits into from
Oct 31, 2023

Conversation

jellespijker
Copy link
Member

@jellespijker jellespijker commented Oct 29, 2023 •
edited by casperlamboo
Loading

CURA-10561

casperlamboo and others added 6 commits October 20, 2023 23:12
@casperlamboo
Make it so QtRenderer can have multiple instances
efe3969
@casperlamboo
Add iso view to snapshot
bdce619
@casperlamboo
Merge pull request #916 from Ultimaker/makerbot-iso-view-renderer
654844a 
Makerbot iso view renderer
@jellespijker
Merge remote-tracking branch 'origin/main' into CURA-10561-makerbot
18aad1a
@jellespijker
Add venv/share to search_paths
6dfd48c 
Contribute to CURA-10561
@jellespijker
Allow sideloading of resources via env
6703910 
`CURA_DATA_ROOT` and `URANIUM_DATA_ROOT`
This allows the conanfile.py to point to `venv/share/cura`

This functionality is disabled in sys.frozen

Contributes to CURA-10561
@github-actions
Copy link

github-actions bot commented Oct 29, 2023 •
edited
Loading

Unit Test Results

2 406 tests  ±0   2 391 ✔️ ±0   29s ⏱️ +3s
       1 suites ±0        15 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit dfa10ef. ± Comparison against base commit 72f42e7.

♻️ This comment has been updated with latest results.

@casperlamboo casperlamboo changed the title CURA 10561 makerbot MakerBot plugin Oct 30, 2023
wawanbreton
wawanbreton reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark/question. The rest is quite harmless :)

UM/Application.py Show resolved Hide resolved
@jellespijker jellespijker marked this pull request as ready for review October 30, 2023 11:25
@jellespijker jellespijker merged commit cc0f88f into main Oct 31, 2023
5 checks passed
@jellespijker jellespijker deleted the CURA-10561-makerbot branch October 31, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jellespijker @wawanbreton @casperlamboo