Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anst/improvements #237

Merged
merged 11 commits into from
Apr 24, 2021
Merged

Anst/improvements #237

merged 11 commits into from
Apr 24, 2021

Conversation

achimmihca
Copy link
Collaborator

@achimmihca achimmihca commented Apr 8, 2021

What does this PR do?

This is PR fixes some issues and prepares the next release.

Versioning

  • The BuildInfoGenerator adds the commit hash of git to the VERSION.txt file (e.g. 5e07588). And the MainScene shows this next to the regular semantic version number.
    • I realized that some automatic mechanism is needed to tell builds apart. The previous build-timestamp approach is not optimal, because the same code base could be build at a different time. The commit hash is a better automatic identifier for the version.
  • The regular semantic version number in VERSION.txt is now taken from the ProjectSettings.
    • This way, only one version must be adjusted.
    • ProjectSettings.bundleVersion is probably more important because this could affect other places, such as Google Play Store, App Store, etc. Thus, this value is copied to VERSION.txt and not vice versa

Refactoring

  • Many files changed because I removed List<IDisposable> and instead use UniRx' extension method AddTo(GameObject)
    • The extension method calls Dispose() in OnDestroy of the GameObject, just like before

fixes

  • The (dis)connect event of a companion app was not handled in some places (e.g. SongSelect). This has been improved.

- makes it easier to tell different builds apart
- show this hash in MainScene to tell builds apart
    - the commit is unique for a release. Thus, show build timestamp only in debug builds as additional info
    - the ip-addess was used as ClientId before. Bus this can change when the device re-connects or the router is reset
    - a UUID is created now on first start of the companion app to identify the device
@achimmihca
Copy link
Collaborator Author

@basisbit any news on this PR?

@basisbit basisbit self-assigned this Apr 22, 2021
@basisbit basisbit merged commit 27df76a into master Apr 24, 2021
@basisbit basisbit deleted the anst/improvements branch April 24, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants