CI: upgrade to NSIS 3.05 #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another day, another CI fix...
This hopefully fixes the super-flaky Windows builds. I've tested that the Windows installer built in the CI with NSIS 3.05 works
Background:
As part of the Windows CI, we so far downgraded the installed NSIS version on the runner from 3.10 to 3.04, which is the version used by AppVeyor. Version 3.06 introduced a bug that made the installer crash after language selection, and a later version seemingly introduced another bug that made the installer crash even before that.
It seems like there's something going wrong with the down-grading process some of the time, as the random build failures complain about a missing function (
LoadAndSetImage) that was only added in NSIS 3.05.For now, I've tried repeating CI runs for both 3.04 and 3.05. The former led to a build failure with the aforementioned bug in 3 out of 10 runs, the latter never produced this bug at all in 17 runs so far.
In the long-term, we should probably look into finding out what goes wrong with the downgrade, or find the issue and contribute an upstream patch.