Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UltraStar Creator continues even if no audio device can be found #27

Closed
Profpatsch opened this issue Nov 3, 2023 · 2 comments · Fixed by #49
Closed

UltraStar Creator continues even if no audio device can be found #27

Profpatsch opened this issue Nov 3, 2023 · 2 comments · Fixed by #49

Comments

@Profpatsch
Copy link

if (BASS_Init(-1, 44100, 0, 0, NULL)) {
QMainWindow::statusBar()->showMessage(tr("BASS initialized."));
}

I’m trying to update USC on nixpkgs, and was bitten by this issue; the return value of BASS_Init is checked, but the software just continues if init fails. This will lead to an infinite loop when the first mp3 is selected, causing USC to hang.

I don’t think it makes much sense to continue initialization if the audio library fails, an error should be displayed and the program should exit instead.

@Profpatsch
Copy link
Author

Thanks to @aszlig for debugging this!!

@DeinAlptraum
Copy link
Collaborator

Thank you for debugging and reporting this! This will be fixed with the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants