Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side chunk sending decision #174

Merged
merged 42 commits into from
May 22, 2021
Merged

Server-side chunk sending decision #174

merged 42 commits into from
May 22, 2021

Conversation

Unarelith
Copy link
Owner

@Unarelith Unarelith commented May 18, 2021 •
edited
Loading

Currently, clients have to send chunk requests to get chunk data.

This PR attempts to give this role to server only, and oh boy it's a lot of work.

Major changes:

  • Client doesn't request the chunks to the server anymore, the server itself decides which chunks it sends.
  • Server now has a renderDistance config option
  • Server now sends keeps track of locally loaded chunks and sends ChunkUnload when needed.
  • Client now sends PlayerChunkPosUpdate each time the player changes chunk.
  • The client is no longer iterating on every chunk, but uses a queue of "dirty" chunks instead.
  • Added backtrace printer tool (only for debug purpose).
  • Added a debug lightmap viewer (available in game through Settings -> Debug)
  • Added ClientProfiler debug tool (unused).
  • Added another mode to debug Minimap to see the amount of times the same chunk have been received.

Known issues:

  • Server crashes when entering another dimension
  • There's a 5 seconds lag when entering a server (probably when using /tp or entering another dimension too)
  • More chunks are updated per frame, so it impacts performance (maybe it's time to improve game loop?)
  • Light is not updated when removing a block

Checklist:

  • Make sure /tp works
  • Heavy lighting checks (sunlight + torchlight)

@Unarelith
2nd attempt.
2410b2c
@Unarelith
[ServerWorld] Fixed infinite loop.
22c77a6
@Unarelith
[ServerWorld] Fixed render distance.
6312213
@Unarelith
[ServerWorld] Chunks are now sent correctly.
f4a229f
@Unarelith
Closest thing to a working version. Still have holes when flying a fe…
1f7d7b6 
…w chunks away.
@Unarelith
Seems to be working, but some trees are incomplete.
a4d1c2c
@Unarelith
Fixed incomplete trees.
1db8d56
@Unarelith
[ClientWorld] Renamed 'isChunkRequested' to 'isReadyForMeshing'.
89b083f
@Unarelith
[ClientChunk] Added a timer to limit chunk updates. [ClientWorld] Imp…
46ca172 
…roved the way cfar chunks are removed.
@Unarelith
Various fixes.
93236cf
@Unarelith
Best working version.
2aa2e34
@Unarelith
[default/listeners.lua] Changed intro text.
0c667ae 
[external/gamekit] Updated.
@Unarelith
Moved ChunkUnload sending from client to server.
c04a48f
@Unarelith
[ClientWorld] Client is no longer in charge of removing chunks.
91d63bd
@Unarelith
[PlayerList] Now clearing player loaded chunks when disconnecting.
75eab2d
@Unarelith
[ClientWorld] Client still needs to remove empty chunks it creates.
94eb509
@Unarelith
[ServerWorld] Now sending ChunkUnload when needed.
6747dd9
@Unarelith
[ServerWorld] Fixed holes in the world.
c259740
@Unarelith
[ClientPlayer] Now sending PlayerChunkPosUpdate.
66478d6
@Unarelith
Improved server-side player chunk management.
97718d2 
- [ServerCommandHandler] Now handling PlayerChunkPosUpdate.
- [ServerChunk] sendChunkData moved from ServerWorld.
- [ServerWorld] Now using PlayerChunkPosUpdate instead of the old loop.
@Unarelith
Attempting to remove the big loops in ClientWorld and ServerWorld.
9091003
@Unarelith
[external/backtrace] Added backtrace printer tool.
079d4e2
@Unarelith
ChunkLightmap::updateLights() no longer returns a boolean.
620d3e1 
Updating lights will already enable hasChanged flag of the correct chunks if needed.
@Unarelith
[DebugLightmapViewer] Added.
d26cd41
@Unarelith
[ClientWorld] Now removes far uninitialized chunks.
14c5b7b
@Unarelith
[ServerChunk] Only update light with all neighbours.
0d480c7 
Also wait for m_readyToSend to be true.
@Unarelith
[ServerWorld] Tried to improve chunk sending.
2a9440e
@Unarelith
[ServerWorld] Chunk send requests seems to be working.
95cbb10
@Unarelith
[ClientChunk] Only start meshing if all neighbours are initialized.
2b47796
@Unarelith
No longer using string to represent vertex attr.
afdfee9
@Unarelith Unarelith marked this pull request as ready for review May 21, 2021 17:35
Unarelith added 4 commits May 22, 2021 15:48
@Unarelith
[Minimap] Now allows switching mode with 'M' key.
c2c817b
@Unarelith
[ClientChunk] Cleaned useless code.
79e3247
@Unarelith
Cleaned useless commented code.
3873278
@Unarelith
[ChunkLightmap] Removed useless lines.
10f605e 
It doesn't seem the engine needs to revert addSunlight anymore, but it may be subject to change, so I removed it as long as I don't see another problem.
@Unarelith Unarelith merged commit ebe9887 into master May 22, 2021
@Unarelith Unarelith deleted the server-side-chunk-sending-2 branch May 22, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Unarelith