added driver for ads130e08 adc #462
Conversation
| @@ -0,0 +1,689 @@ | |||
| /* | |||
| * The MIT License (MIT) | |||
There was a problem hiding this comment.
the source code says it's MIT, but the license file says otherwise. which is the one you intended?
There was a problem hiding this comment.
MIT ... fixed on commit #b4e1988
|
|
||
| CHECK(read_reg_8(dev, ADS130E08_REG_CONFIG1, &config1)); | ||
|
|
||
| config->clk_en = (config1 & CONFIG1_MASK_BITS_CLK_EN); |
There was a problem hiding this comment.
fixed on commit #b3f0e37
examples/ads130e08/default/README.md
Outdated
|
|
||
| ## What it does | ||
|
|
||
| The example configures one `ADS130E08` device on a `SPI` bus. |
There was a problem hiding this comment.
would you elaborate a bit more? logs from a successful test would be also nice.
There was a problem hiding this comment.
Sure. I'll add it shortly.
| depends: | ||
| thread_safe: yes | ||
| targets: | ||
| - name: esp32 |
There was a problem hiding this comment.
do you have ESP32C3 or other chips to test? with changes to the pin assignment, it should work. if you don't, something like "should work on other ESP32" in the doc would be nice.
There was a problem hiding this comment.
I don't have other ESP32 chips to test. I'll change the doc and say it may be supported for other chips.
|
@trombik , I made the improvements |
…x readme, add label
|
@weslleymfd I am bit busy today and the weekend. but @UncleRus would comment if he has any (and I'm really happy to see his commit again!) |
|
@weslleymfd @trombik Thank you! |
Hello there,
Here is a driver that I developed for ESP32 to work with the ADS130E08 ADC from Texas Instruments.