Optimize TexData (mostly QoiConverter) #886
Conversation
|
Did you look at the changed files? |
Oh. |
This reverts commit b54a4a7.
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miepee
reviewed
May 4, 2022
Miepee
reviewed
May 5, 2022
Miepee
approved these changes
May 5, 2022
Miepee
added a commit
to Miepee/UndertaleModTool
that referenced
this pull request
May 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes QoiConverter, makes TexData store a bitmap instead of PNG byte array and replaces most TextureBlob usages with a direct reference to the bitmap
The memory usage deserializing QOI images is drastically lower:
There isn't much that can be optimized in the serialization but it's still a bit better:old screenshot
Memory usage here is also way lower in serialization now (about 40MB, instead of 380MB on a random 4K wallpaper image)