-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build musllinux
wheels
#307
Comments
I created PR #308 - and it shows the same test failure, only for Python 3.9 for some reason. It is true that long doubles are actually 80, not 128 bits on x86_64, but that doesn't explain why all the x86_64 tests pass except for musllinux with python 3.9. |
It also fails for Python 3.10 and 3.11, it's just that since 3.9 fails first it doesn't try testing those ones. |
I don't think it's a Python version issue, but a numpy version issue. With Python 3.7 and 3.8, it's using an older version of numpy. |
PR #308 merged, musllinux wheels should be created in the next release |
As of numpy 1.25,
musllinux
wheels are built and distributed on PyPI, supplementing the existingmanylinux
ones. It would be helpful for cftime to likewise build wheels for this platform.It should essentially be a matter of updating the
.github/workflows/cibuildwheel.yml
to remove*musllinux*
from theCIBW_SKIP
variable. However, when I tried running it locally, the wheels built successfully but one test fails:It looks like numpy has had some similar test failures for
long double
s using musl. This comment identified that on the x86_64 architecture,long double
is actually the x87 80-bit float, not the IEEE-754 128-bit float type.The text was updated successfully, but these errors were encountered: