Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeing compile warnings in bigmeta.c #1079

Closed
edhartnett opened this issue Jul 20, 2018 · 1 comment · Fixed by #1087
Closed

Seeing compile warnings in bigmeta.c #1079

edhartnett opened this issue Jul 20, 2018 · 1 comment · Fixed by #1087

Comments

@edhartnett
Copy link
Contributor

I am seeing compile warnings from this test program:

bigmeta.c: In function ‘buildatts’:
bigmeta.c:137:9: warning: unused variable ‘attid’ [-Wunused-variable]
     int attid;
         ^~~~~
bigmeta.c: In function ‘buildgroup’:
bigmeta.c:152:40: warning: unused variable ‘attid’ [-Wunused-variable]
     int i, grpid, dimid, typid, varid, attid;
                                        ^~~~~
bigmeta.c:152:26: warning: unused variable ‘typid’ [-Wunused-variable]
     int i, grpid, dimid, typid, varid, attid;
                          ^~~~~
bigmeta.c:152:19: warning: unused variable ‘dimid’ [-Wunused-variable]
     int i, grpid, dimid, typid, varid, attid;
                   ^~~~~
bigmeta.c: In function ‘main’:
bigmeta.c:198:37: warning: unused variable ‘attid’ [-Wunused-variable]
     int grpid, dimid, varid, typid, attid;
                                     ^~~~~
bigmeta.c:198:30: warning: unused variable ‘typid’ [-Wunused-variable]
     int grpid, dimid, varid, typid, attid;
                              ^~~~~
bigmeta.c:198:23: warning: unused variable ‘varid’ [-Wunused-variable]
     int grpid, dimid, varid, typid, attid;
                       ^~~~~
bigmeta.c:198:16: warning: unused variable ‘dimid’ [-Wunused-variable]
     int grpid, dimid, varid, typid, attid;
                ^~~~~
bigmeta.c:198:9: warning: unused variable ‘grpid’ [-Wunused-variable]
     int grpid, dimid, varid, typid, attid;
         ^~~~~
bigmeta.c:196:9: warning: unused variable ‘stat’ [-Wunused-variable]
     int stat = NC_NOERR;
         ^~~~
@WardF WardF closed this as completed Jul 23, 2018
@WardF
Copy link
Member

WardF commented Jul 23, 2018

There doesn’t appear to be anything serious reported by these warnings, and doesn’t really merit an open issue

@edhartnett edhartnett mentioned this issue Jul 24, 2018
Closed
DennisHeimbigner added a commit that referenced this issue Jul 27, 2018
@DennisHeimbigner
This PR primarily addresses Issue #725.
b02703a 
After a long discussion, I implemented the rules at the end of that issue.
They are documented in nccopy.1.

Additionally, I added a new, per-variable, -c flag that allows
for the direct setting of the chunking parameters for a variable.
The form is
    -c var:c1,c2,...ck
where var is the name of the variable (possibly a fully qualified name)
and the ci are the chunksizes for that variable. It must be the case
that the rank of the variable is k. If the new form is used as well
as the old form, then the new form overrides the old form for the
specified variable. Note that multiple occurrences of the new form
-c flag may be specified.

Misc. Other fixes
1. Added -M <size> option to nccopy to specify the minimum
   allowable chunksize.
2. Removed the unused variables from bigmeta.c
   (Issue #1079)
3. Fixed failure of nc_test4/tst_filter.sh by using the new -M
   flag (#1) to allow filter test on a small chunk size.
@DennisHeimbigner DennisHeimbigner mentioned this issue Jul 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@WardF @edhartnett