Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing file ncdap_test/manyurls.h #2091

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

DennisHeimbigner
Copy link
Collaborator

re: Github Issue: #2085

The file ncdap_test/manyurls.h was not added to the repository.
It is controlled by the --enable-dap-long-tests option.
Solution: add the file.

re: Github Issue: Unidata#2085

The file ncdap_test/manyurls.h was not added to the repository.
It is controlled by the --enable-dap-long-tests option.
Solution: add the file.
@dopplershift
Copy link
Member

Is nothing building in CI that should have caught that?

@DennisHeimbigner
Copy link
Collaborator Author

This is controlled by --enable-dap-long-tests, which is one of a number of
options unlikely to be used, and so not tested routinely. There are a number of others,
Perhaps we should have a non-matrix'ized github action that is specifically to test
some of these outlier options.

@DennisHeimbigner
Copy link
Collaborator Author

BTW, the reason we don't add a row to the matrix for these is that the size of the matrix
is limited and we would soon exceed the allowed size for matrices.

@WardF
Copy link
Member

WardF commented Aug 24, 2021

I've merged this in to #2093 and am expanding the github actions to make sure that adding the missing file doesn't result in new/different failures.

@WardF
Copy link
Member

WardF commented Aug 24, 2021

@DennisHeimbigner I'm seeing failures when enabling enable-dap-long-tests. I'll start debugging these, but you can see the details over at #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants