Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ZSTD to netcdf_meta.h and libnetcdf.settings #2287

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

edwardhartnett
Copy link
Contributor

Fixes #2275

added ZSTD to netcdf_meta.h and libnetcdf.settings

I've checked with both autotools and CMake.

(This PR also incorporates #2286)

@edwardhartnett edwardhartnett requested a review from WardF as a code owner April 11, 2022 14:05
Copy link
Member

@WardF WardF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good change, thank you very much!

@WardF WardF added this to the 4.9.0 milestone Apr 11, 2022
@WardF WardF self-assigned this Apr 11, 2022
@WardF WardF merged commit 24835e0 into Unidata:main Apr 11, 2022
@DennisHeimbigner
Copy link
Collaborator

Why is the "Standard Filters: @STD_FILTERS@"
line in libnetcdf.settings.in good enough?

@gsjaardema
Copy link
Contributor

Thank you. Looks good.

@edwardhartnett
Copy link
Contributor Author

@DennisHeimbigner this is in netcdf_meta.h and gives a simple true/false for zstd, without having to parse anything in pre-processor code.

@edwardhartnett edwardhartnett deleted the ejh_add_zstd_meta branch June 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How detect whether zstd is supported
4 participants