CMake: Add option to always automatically regenerate ncgen source
#2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - ensure `flex` and `bison` are available - run commands from top level directory so `#line` directives in generated files include the `ncgen` subdirectory -- gives better tracing of warnings - include `sed` commands for fixing filename in `#line` directives
|
I think the test failures are spurious: as they only failed in one configuration, and they then pass when immediately rerun |
|
This looks good; I may change the option name to keep it consistent with the |
* main: (209 commits) Bump Visual Studio appveyor, for the brief period before we swap out to GitHub actions. Make a change in support of Unidata#2879 Revert "fix cmake build with ENABLE_HDF4 and hdf requiring jpeg" removing need for global compile definition fix cmake build with ENABLE_HDF4 and hdf requiring jpeg Removed assumption that we are linking against static HDF5 when building a static library. While it's reasonable to provide a mechanism to specify this, it is not necessarily true. We should also perhaps rename the NC_FIND_SHARED option, since LIBS implies it will look for static or shared libraries for all dependencies, but this logic only looks for HDF5. In any case, commenting this out for now until we can rework it. Re-adding global add-definition for the time being. Its lack introduces an unnecessary roadblock (at the moment). Re-formulated logic for determining what tests to run when. Need to figure out why plugins are turned off when MINGW is true, but that's a different issue. As of this push, all tests succeed on local windows system. Update cmake-based plugins and test logic. Modify messages to be more clear. setting dll export on each target Correct lingering compilation issue under Visual Studio. Hopefully I haven't broken the Linux build Addressing a handful of issues encountered in Visual Studio re: linking, setting compiler flags for VC, etc. removing c++ header file from c header Corrected a dependencies issue linking against libcurl and finding curl/curl.h using Visual Studio. There's another issue to correct, but this is getting us a lot closer. Correct(?) syntax with target_compile_options() in top level CMakeLists.txt. Correct the logic flow in libncxml/CMakeLists.txt to not try to include non-existant directory when libxml2 is not found. removing unused cmake updating tests to use correct cmake variable removing possibly redundant cmake for shared library updating release notes bumping cmake version ...
|
Just to note that in the autotools build, Here, this is a configure-time option to enable automatic regeneration of the files. As you note, it's off by default, as this bit of the code rarely changes and means that users don't need to have flex and bison installed normally. |
NETCDF_ prefix. Thanks! Merge remote-tracking branch 'upstream/main' into cmake-ncgen-generate
WardF
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this:
flexandbisonare available#linedirectives in generated files include thencgensubdirectory -- gives better tracing of warningssedcommands for fixing filename in#linedirectivesI found that when trying to fix some warnings from
ncgen.ythat it was quite difficult to correctly regeneratencgeny.c, and I think this was basically because the custom command didn't list all the files it creates. So this PR fixes that, as well as make it easier to regenerate these files -- turning on the optionGENERATE_NCGENcauses CMake to automatically regenerate them as part of the build process if required.I've not done the same thing for
ncgen3/ncgen.yas it looks like that hasn't been regenerated in some time and would result in significant changes. @WardF should I regenerate it too?