Fix warnings in ncgen
#2897
Merged
Fix warnings in ncgen
#2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lots of warnings about conversions changing value
Fixes lots of sign-conversion warnings
* main: (107 commits) Updated Release Notes. A bit of cleanup for now, more to follow, but moving on to other roadblocks. Comment out debugging messages, will remove before final merge. Clean up the logic, remove some rough edges. Add a filter to process options and report deprecation warning. Remove dangling define in netcdf_meta.h template file. No effect other than to remove a personal annoyance I introduced in the first place. Updated the nc-config script with the following: adding deprecation error for usage of NETCDF_ENABLE_NETCDF4 removing cmake alias variable for netcdf4 removing script replacing something that removes semicolons another one fixing some that were missing? removing variables Replacing NC_USE_STATIC_CRT with NETCDF_USE_STATIC_CRT Replace NC_FIND_SHARED_LIBS with NETCDF_FIND_SHARED_LIBS Replace ENABLE_XGETOPT with NETCDF_ENABLE_XGETOPT Replace ENABLE_UNIT_TESTS with NETCDF_ENABLE_UNIT_TESTS Replace ENABLE_TESTS with NETCDF_ENABLE_TESTS Replace ENABLE_STRICT_NULL_BYTE_HEADER_PADDING with NETCDF_ENABLE_STRICT_NULL_BYTE_HEADER_PADDING ...
|
The failing tests on the Mac OS X build passed when rerun on CI. Doesn't look like the usual sporadic failures from the network tests? Also from ncdump tests, which I don't think should be affected by the changes here? |
* main: Set flags to avoid warning messages if curl isn't found. Use modern cmake nomenclature for curl. Skip checking for duplicates if only one element in list Change format of backwards-loops
…runner-based CI on github actions.
WardF
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or silences all warnings in
ncgen. This PR will bring the total warnings down to under 500