-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Setup a CMake job for MSYS2/MinGW #2917
Conversation
This keeps dying on me because apparently m4 is not being installed. |
This PR requires #2914 to be applied first. |
Applied 2914 and it still dies because it cannot find m4. |
It requires some more changes that i will apply one #2914 got merged. |
@DennisHeimbigner I have pushed changes for the build to succeeds, but tests needs more changes to succeed. |
You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin? |
No, WIN32 is not defined by CMake on CygWin. |
@DennisHeimbigner I'm not seeing an issue on my end from the tests, but I don't have a Cygwin environment to run. It works in MSYS2 with Visual Studio, if you run this manually on your Cygwin environment, does it fail? |
DWesl#2 is a copy of this workflow adapted for Cygwin, which shows a single test failure (a massive improvement over the last time I tried CMake on Cygwin). I don't recognize the reason for the |
Can you give a short characterization of the differences between you cygwin .yml |
I added a section to build the software and run tests using CMake. This section differs from the Autotools job in the software installed (the CMake job adds The CMake section differs from the CMake section here in the action used to install packages (Cygwin instead of MSYS/MinGW) and the build generator used (Unix Makefiles instead of MSYS). I also specified more full paths to utilities. Should I make a PR to add that to this PR or create a new PR? |
Thanks! |
No description provided.