Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting/inquiring per variable fill mode for nc3 files #383

Closed
wants to merge 107 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
02d51ca
support setting/inquiring per variable fill mode for nc3 files
Mar 23, 2017
89b6ec2
putting or deleting attribute _FillValue does not automatically turns…
Mar 24, 2017
d23f224
fix minor errors in Makefile.am
Mar 24, 2017
ac5d8e5
check error code NC_ELATEFILL
Mar 24, 2017
a5aa720
NC_EGLOBAL is returned when trying to set global _FillValue
Mar 25, 2017
7a3e935
NC_EGLOBAL is returned when using NC_GLOBAL in nc_inq_var_fill
Mar 25, 2017
68a5783
enable nc_open to check the number of large variables allowed in CDF-…
Apr 4, 2017
1af2643
rename macro ERR to ERR_CHK, as ERR is already defined in err_macros.h
Apr 4, 2017
674d212
fix nc_open_mem
thehesiod Apr 28, 2017
90609f6
fix typo
thehesiod Apr 28, 2017
23c14bd
Merge branch 'master' into nc_open_mem_fix
thehesiod May 1, 2017
09ba25c
fix strange garbage results
thehesiod May 1, 2017
6dc6cf6
re: issue https://github.com/Unidata/netcdf-c/issues/401
DennisHeimbigner May 3, 2017
5a0c7ab
Add testcase
DennisHeimbigner May 3, 2017
455f3b9
typo
DennisHeimbigner May 3, 2017
a8c8143
Revert "fix strange garbage results"
thehesiod May 3, 2017
ce20f3b
Corrected a build issue on windows for tst_diskless5, and updated rel…
WardF May 4, 2017
e39c26d
Merge pull request #403 from Unidata/memio.dmh
WardF May 4, 2017
756dca5
Merge branch 'master' into nc_open_mem_fix
WardF May 4, 2017
e29dc26
Merge pull request #400 from thehesiod/nc_open_mem_fix
WardF May 5, 2017
051bd3b
Merge branch 'master' into open_check_vlens
WardF May 5, 2017
e1ff8f9
Merge pull request #393 from wkliao/open_check_vlens
WardF May 8, 2017
f8c7df7
Corrected an issue where run_diskless2.sh was not properly configured.
WardF May 10, 2017
e8ebe66
Addressing issues in large file tests on Windows.
WardF May 12, 2017
9c78b46
Restored some file checks.
WardF May 12, 2017
c685174
Merge branch 'gh385-lfs' of github.com:Unidata/netcdf-c into gh385-lfs
WardF May 12, 2017
42ba263
Corrected an else statement.
WardF May 12, 2017
9408607
Added a version of config.h.cmake.in, based on the version from 4.4.1…
WardF May 23, 2017
cfdc3ea
Restored the old non-working config.h template so that the comparison…
WardF May 23, 2017
ac56c10
Updated config.h template for CMake with some large file info.
WardF May 23, 2017
b88507e
More rigorous sync between old config.h cmake template and the curren…
WardF May 23, 2017
b717a22
Corrected a typo.
WardF May 23, 2017
f29ae34
Corrected another typo.
WardF May 23, 2017
68f5e3a
No idea how this was possibly working, previously.
WardF May 23, 2017
f710b29
Updated release notes.
WardF May 24, 2017
59ded4a
Moving some tests around so that 'make check' works properly, in supp…
WardF May 24, 2017
cc496d0
Corrected a typo.
WardF May 24, 2017
7902b56
Added missing scripts.
WardF May 24, 2017
37e3f0a
Removed redundant scripts.
WardF May 24, 2017
6e0f17f
Updated release notes in support of the fix for https://github.com/Un…
WardF May 24, 2017
02a6585
Corrected some typos.
WardF May 24, 2017
2fec785
Fix method of finding ncxx[4]-config for non-bash shells
ZedThree May 30, 2017
26f8ebd
Computed new interace version flags.
WardF May 30, 2017
c0c9c60
Additional tweaking.
WardF May 30, 2017
310f1f8
Added flag to tst_dimsizes.sh to dump on error.
WardF May 30, 2017
fb457f2
Moved error code to common shell.
WardF May 30, 2017
7144cfb
More debugging info.
WardF May 30, 2017
5b6e31f
Deleted some old files.
WardF May 31, 2017
f4151c9
Reverted changes to X_get_size_t, in order to correct an issue
WardF May 31, 2017
2375948
Updated release notes in support of https://github.com/Unidata/netcdf…
WardF May 31, 2017
a2d7a09
Merge branch 'gh410' of github.com:Unidata/netcdf-c into gh410
WardF May 31, 2017
1a2716b
Changed the shell for a test to bash to catch a missing utility in so…
WardF May 31, 2017
9a8af91
Copying files as needed for hdf4 tests.
WardF May 31, 2017
03c67cb
Updated src path in hdf4 chunk test.
WardF May 31, 2017
9823d73
Corrected a logic error.
WardF May 31, 2017
5699a32
Updated cleanfiles list on Makefile.am
WardF May 31, 2017
05e2ff3
Sorting out hdf4 chunk tests.
WardF May 31, 2017
ebd1fca
Working on reformulating test_common.sh
WardF May 31, 2017
ef450c4
Refactoring test_common.sh template.
WardF May 31, 2017
df872ac
Continued refactoring.
WardF May 31, 2017
128fb56
Trying distcleanfiles experiment.
WardF Jun 1, 2017
08f7d06
Refactoring hdf4 chunking test in similar fashion to hdf5 compatibili…
WardF Jun 1, 2017
a077289
Refactored hdf4 chunking test a little bit.
WardF Jun 1, 2017
1f96a66
hdf4 chunking file rename
WardF Jun 1, 2017
f1f7224
Corrected a false positive.
WardF Jun 1, 2017
cebc930
Merge branch 'gh410'
WardF Jun 1, 2017
ec33411
Bumped revision information to next version.
WardF Jun 1, 2017
bad0058
Corrected a missed string.
WardF Jun 1, 2017
81b0ab9
Fixed a missing file.
WardF Jun 1, 2017
cc08dfd
Removed an unnecessary template file.
WardF Jun 1, 2017
89ebc2b
Fixed an issue on visual studio which can result in a race state (mor…
WardF Jun 1, 2017
c0d9c7c
Merge branch 'master' into fix-find-ncxx-configs
WardF Jun 2, 2017
ff8b93a
Bumped release date.
WardF Jun 5, 2017
ecd40e6
Removed old unused file, static html version was moved into static/ s…
WardF Jun 6, 2017
ebed788
Use H5free_memory instead of free
gsjaardema Jun 6, 2017
b039216
Made memory free method conditional, based on if H5free_memory is ava…
WardF Jun 6, 2017
8f2f9b7
re: pull request https://github.com/Unidata/netcdf-c/pull/364
DennisHeimbigner Jun 6, 2017
30846cf
Cmake
DennisHeimbigner Jun 6, 2017
29ae0b7
X_INT64_MIN, X_INT64_MAX, and X_UINT64_MAX should be used internally
wkliao Jun 6, 2017
d02e3c9
Fix memory leak in NC4_put_propattr()
rouault Jun 7, 2017
d755971
Merge branch 'fix_leak_in_NC4_put_propattr' of https://github.com/rou…
WardF Jun 7, 2017
1d9bd60
Merge branch 'remove_x_int64' of https://github.com/wkliao/netcdf-c i…
WardF Jun 7, 2017
6da1539
Removed software.md from dist file.
WardF Jun 7, 2017
3a0b0d5
Replaced sed with configure_ac_files, since sed may not be available.
WardF Jun 7, 2017
4d941f5
Corrected release notes.
WardF Jun 7, 2017
40f6164
Corrected release notes again.
WardF Jun 7, 2017
af91d03
Merge branch 'fix-find-ncxx-configs' of https://github.com/ZedThree/n…
WardF Jun 7, 2017
4097dd9
Change to address issue reported in https://github.com/Unidata/netcdf…
WardF Jun 8, 2017
b73c816
Removed a line in configure.ac that is potentially redundant and thro…
WardF Jun 8, 2017
308c2f7
struct stat.st_size is of type off_t
wkliao Jun 9, 2017
12d224e
Corrected an issue in support of https://github.com/Unidata/netcdf-c/…
WardF Jun 9, 2017
9227007
Merge branch 'nc_get_filelen' of https://github.com/wkliao/netcdf-c i…
WardF Jun 9, 2017
08c51e6
Corrected a couple issues uncovered when revisiting https://github.co…
WardF Jun 14, 2017
b3418d2
Fix undefined left shift in ncx_get_size_t()
rouault Jun 15, 2017
8a4f5ae
Corrected a double-free reported by static analysis.
WardF Jun 15, 2017
e2e7c20
Merge branch 'v4.5.0-release-branch' into ncgenutf8.dmh
DennisHeimbigner Jun 18, 2017
9cde916
re: pull request https://github.com/Unidata/netcdf-c/pull/364
DennisHeimbigner Jun 19, 2017
3cded7e
Merge pull request #430 from Unidata/ncgenutf8.dmh
WardF Jun 20, 2017
4779c82
Fix undefined left shift in get_ix_int()
rouault Jun 23, 2017
8ee484b
Merge branch 'fix_undefined_left_shift_in_ncx_get_size_t' of https://…
WardF Jun 26, 2017
dc9e31d
Fix for github issue https://github.com/Unidata/netcdf-c/issues/310.
DennisHeimbigner Jun 28, 2017
0ae2232
Forgot to add test files to github
DennisHeimbigner Jun 28, 2017
ed4dfb4
Testing something with the pure h5 tests.
WardF Jun 28, 2017
d73c501
Merge remote-tracking branch 'origin/issue310.dmh' into gh434
WardF Jun 29, 2017
fd2c575
Updated release notes.
WardF Jun 29, 2017
228b0c4
merge the latest master branch
wkliao Jul 1, 2017
db1dcab
patch for dap4 support
wkliao Jul 1, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ set(PACKAGE "netCDF" CACHE STRING "")
#####

SET(NC_VERSION_MAJOR 4)
SET(NC_VERSION_MINOR 4)
SET(NC_VERSION_PATCH 2)
SET(NC_VERSION_MINOR 5)
SET(NC_VERSION_PATCH 1)
SET(NC_VERSION_NOTE "-development")
SET(netCDF_VERSION ${NC_VERSION_MAJOR}.${NC_VERSION_MINOR}.${NC_VERSION_PATCH}${NC_VERSION_NOTE})
SET(VERSION ${netCDF_VERSION})
SET(NC_VERSION ${netCDF_VERSION})
SET(netCDF_LIB_VERSION 11.4.0)
SET(netCDF_SO_VERSION 11)
SET(netCDF_LIB_VERSION 13)
SET(netCDF_SO_VERSION 13)
SET(PACKAGE_VERSION ${VERSION})

# Get system configuration, Use it to determine osname, os release, cpu. These
Expand Down Expand Up @@ -645,7 +645,7 @@ IF(USE_HDF5 OR ENABLE_NETCDF_4)
SET(HDF5_C_LIBRARY hdf5)
ENDIF()
ENDIF(HDF5_C_LIBRARY AND HDF5_HL_LIBRARY AND HDF5_INCLUDE_DIR)

# There is a missing case in the above code so default it
IF("${HDF5_C_LIBRARY_hdf5}" STREQUAL "" )
SET(HDF5_C_LIBRARY_hdf5 "${HDF5_C_LIBRARY}")
Expand Down Expand Up @@ -1272,6 +1272,11 @@ IF(SIZEOF_UINT)
SET(HAVE_UINT TRUE)
ENDIF(SIZEOF_UINT)

CHECK_TYPE_SIZE("schar" SIZEOF_SCHAR)
IF(SIZEOF_SCHAR)
SET(HAVE_SCHAR TRUE)
ENDIF(SIZEOF_SCHAR)

CHECK_TYPE_SIZE("long" SIZEOF_LONG)
CHECK_TYPE_SIZE("long long" SIZEOF_LONG_LONG)
IF(SIZEOF_LONG_LONG)
Expand Down Expand Up @@ -1860,6 +1865,7 @@ SET(host_cpu "${cpu}")
SET(host_vendor "${osname}")
SET(host_os "${osrel}")
SET(abs_top_builddir "${CMAKE_BINARY_DIR}")
SET(abs_top_srcdir "${CMAKE_SOURCE_DIR}")

SET(CC_VERSION "${CMAKE_C_COMPILER}")

Expand Down
18 changes: 14 additions & 4 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,31 @@ Release Notes {#RELEASE_NOTES}

This file contains a high-level description of this package's evolution. Releases are in reverse chronological order (most recent first). Note that, as of netcdf 4.2, the `netcdf-c++` and `netcdf-fortran` libraries have been separated into their own libraries.

## 4.4.2 - TBD
## 4.5.0 - TBD

### 4.5.0-rc2 - TBD

* [Bug Fix] Addressed an issue where ncgen would not respect keyword case. See [GitHub #310](https://github.com/Unidata/netcdf-c/issues/310) for more information.

### 4.5.0-rc1 - June 5, 2017

* [Enhancement] DAP4 is now included. Since dap2 is the default for urls, dap4 must be specified by
(1) using "dap4:" as the url protocol, or
(2) appending "#protocol=dap4" to the end of the url, or
(3) appending "#dap4" to the end of the url
(3) appending "#dap4" to the end of the url
Note that dap4 is enabled by default but remote-testing is
disbled until the testserver situation is resolved.
* [Enhancement] The remote testing server can now be specified with the '--with-testserver" option to ./configure.
* [Enhancement] The remote testing server can now be specified with the `--with-testserver` option to ./configure.
* [Enhancement] Modified netCDF4 to use ASCII for NC_CHAR. See [Github Pull request #316](https://github.com/Unidata/netcdf-c/pull/316) for more information.
* [Bug Fix] Corrected an error with how dimsizes might be read. See [Github #410](https://github.com/unidata/netcdf-c/issues/410) for more information.
* [Bug Fix] Corrected an issue where 'make check' would fail if 'make' or 'make all' had not run first. See [Github #339](https://github.com/Unidata/netcdf-c/issues/339) for more information.
* [Bug Fix] Corrected an issue on Windows with Large file tests. See [Github #385](https://github.com/Unidata/netcdf-c/issues/385]) for more information.
* [Bug Fix] Corrected an issue with diskless file access, see [Pull Request #400](https://github.com/Unidata/netcdf-c/issues/400) and [Pull Request #403](https://github.com/Unidata/netcdf-c/issues/403) for more information.
* [Upgrade] The bash based test scripts have been upgraded to use a common test_common.sh include file that isolates build specific information.
* [Upgrade] The bash based test scripts have been upgraded to use a common test_common.sh include file that isolates build specific information.
* [Refactor] the oc2 library is no longer independent of the main netcdf-c library. For example, it now uses ncuri, nclist, and ncbytes instead of its homegrown equivalents.
* [Bug Fix] `NC_EGLOBAL` is now properly returned when attempting to set a global `_FillValue` attribute. See [GitHub #388](https://github.com/Unidata/netcdf-c/issues/388) and [GitHub #389](https://github.com/Unidata/netcdf-c/issues/389) for more information.
* [Bug Fix] Corrected an issue where data loss would occur when `_FillValue` was mistakenly allowed to be redefined. See [Github #390](https://github.com/Unidata/netcdf-c/issues/390), [GitHub #387](https://github.com/Unidata/netcdf-c/pull/387) for more information.
* [Enhancement] Modified netCDF4 to use ASCII for NC_CHAR. See [Github Pull request #316](https://github.com/Unidata/netcdf-c/pull/316) for more information.
* [Upgrade][Bug] Corrected an issue regarding how "orphaned" DAS attributes were handled. See [GitHub #376](https://github.com/Unidata/netcdf-c/pull/376) for more information.
* [Upgrade] Update utf8proc.[ch] to use the version now maintained by the Julia Language project (https://github.com/JuliaLang/utf8proc/blob/master/LICENSE.md).
* [Bug] Addressed conversion problem with Windows sscanf. This primarily affected some OPeNDAP URLs on Windows. See [GitHub #365](https://github.com/Unidata/netcdf-c/issues/365) and [GitHub #366](https://github.com/Unidata/netcdf-c/issues/366) for more information.
Expand Down
3 changes: 1 addition & 2 deletions cf
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ MALLOC_CHECK=""
CPPFLAGS=""
LDFLAGS=""

#CFLAGS="-g -O0 $CFLAGS"
CFLAGS="-g $CFLAGS"
CFLAGS="-g -O0 $CFLAGS -Wno-undefined"

MAKE=make
IGNORE="test 0 = 1"
Expand Down
2 changes: 1 addition & 1 deletion cf.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Visual Studio
#VS=1
VS=1

# Is netcdf-4 and/or DAP enabled?
NC4=1
Expand Down
58 changes: 55 additions & 3 deletions config.h.cmake.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@

#ifdef _MSC_VER

/* Prevent an issue where there is a circular inclusion
of winsock.h/windows.h. This weird state occurs with
libdap4 and hdf4 support. The solution comes from the
following URL, found after a bit of research.

Added in support of the 4.5.0-rc1. Hello, future generations.

* https://stackoverflow.com/questions/1372480/c-redefinition-header-files-winsock2-h

*/
#define _WINSOCKAPI_

#if _MSC_VER>=1900
#define STDC99
#endif
Expand Down Expand Up @@ -49,6 +61,12 @@ are set when opening a binary file on Windows. */

#cmakedefine const

#ifndef _FILE_OFFSET_BITS
#cmakedefine _FILE_OFFSET_BITS ${_FILE_OFFSET_BITS}
#cmakedefine _LARGEFILE64_SOURCE
#cmakedefine _LARGEFILE_SOURCE
#endif

/* Define if building universal (internal helper macro) */
#cmakedefine AC_APPLE_UNIVERSAL_BUILD 1

Expand Down Expand Up @@ -168,6 +186,13 @@ are set when opening a binary file on Windows. */
/* Define to 1 if you have the <fcntl.h> header file. */
#cmakedefine HAVE_FCNTL_H 1

/* Define to 1 if you have the BaseTsd.h header file. */
#cmakedefine HAVE_BASETSD_H @HAVE_BASETSD_H@

/* Define if we have filelengthi64. */
#cmakedefine HAVE_FILE_LENGTH_I64 @HAVE_FILE_LENGTH_I64@


/* Define to 1 if you have the `fsync' function. */
#cmakedefine HAVE_FSYNC 1

Expand Down Expand Up @@ -204,6 +229,9 @@ are set when opening a binary file on Windows. */
/* Define to 1 if you have the <hdf5.h> header file. */
#cmakedefine HAVE_HDF5_H 1

/* Define to 1 if you have the <hdf5.h> header file. */
#cmakedefine HAVE_HDF5_HL_H 1

/* Define to 1 if the system has the type `int64'. */
#cmakedefine HAVE_INT64 1

Expand Down Expand Up @@ -315,12 +343,18 @@ are set when opening a binary file on Windows. */
/* Define to 1 if you have the `strdup' function. */
#cmakedefine HAVE_STRDUP 1

/* Define to 1 if you have the `strndup` function. */
#cmakedefine HAVE_STRNDUP

/* Define to 1 if you have the `strerror' function. */
#cmakedefine HAVE_STRERROR 1

/* Define to 1 if you have the <strings.h> header file. */
#cmakedefine HAVE_STRINGS_H 1

/* Define to 1 if you have the <signal.h> header file. */
#cmakedefine HAVE_SIGNAL_H 1

/* Define to 1 if you have the <string.h> header file. */
#cmakedefine HAVE_STRING_H 1

Expand All @@ -342,6 +376,9 @@ are set when opening a binary file on Windows. */
/* Define to 1 if you have the `strtoull' function. */
#cmakedefine HAVE_STRTOULL 1

/* Define to 1 if you have the `stroull' function. */
#cmakedefine HAVE_STROULL 1

/* Define to 1 if `st_blksize' is a member of `struct stat'. */
#cmakedefine HAVE_STRUCT_STAT_ST_BLKSIZE 1

Expand Down Expand Up @@ -378,6 +415,9 @@ are set when opening a binary file on Windows. */
/* Define to 1 if you have <sys/wait.h> that is POSIX.1 compatible. */
#cmakedefine HAVE_SYS_WAIT_H 1

/* Define to 1 if the system has the type `schar'. */
#cmakedefine HAVE_SCHAR 1

/* Define to 1 if the system has the type `uchar'. */
#cmakedefine HAVE_UCHAR 1

Expand Down Expand Up @@ -428,6 +468,18 @@ are set when opening a binary file on Windows. */
/* no IEEE float on this platform */
#cmakedefine NO_IEEE_FLOAT 1

#cmakedefine BUILD_V2 1
#cmakedefine ENABLE_DOXYGEN 1
#cmakedefine ENABLE_INTERNAL_DOCS 1
#cmakedefine VALGRIND_TESTS 1
#cmakedefine ENABLE_CDMREMOTE 1
#cmakedefine USE_HDF5 1
#cmakedefine ENABLE_FILEINFO 1
#cmakedefine TEST_PARALLEL ${TEST_PARALLEL}
#cmakedefine BUILD_RPC 1
#cmakedefine USE_X_GETOPT 1
#cmakedefine ENABLE_EXTREME_NUMBERS 1

/* do not build the netCDF version 2 API */
#cmakedefine NO_NETCDF_2 1

Expand Down Expand Up @@ -464,6 +516,9 @@ are set when opening a binary file on Windows. */
/* The size of `longlong` as computed by sizeof. */
#cmakedefine SIZEOF_LONGLONG @SIZEOF_LONGLONG@

/* The size of `char` as computed by sizeof. */
#cmakedefine SIZEOF_CHAR @SIZEOF_CHAR@

/* The size of `uchar` as computed by sizeof. */
#cmakedefine SIZEOF_UCHAR @SIZEOF_UCHAR@

Expand Down Expand Up @@ -619,9 +674,6 @@ are set when opening a binary file on Windows. */
# define _DARWIN_USE_64_BIT_INODE 1
#endif

/* Number of bits in a file offset, on hosts where this is settable. */
#cmakedefine _FILE_OFFSET_BITS ${_FILE_OFFSET_BITS}

/* Define for large files, on AIX-style hosts. */
#cmakedefine _LARGE_FILES ${_LARGE_FILES}

Expand Down
Loading