-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2 broken parallel tests, clean out some remaining support for legacy cfortran build and upper-case mod file names #162
Merged
WardF
merged 22 commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_fort_par
Mar 20, 2019
Merged
Fix 2 broken parallel tests, clean out some remaining support for legacy cfortran build and upper-case mod file names #162
WardF
merged 22 commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_fort_par
Mar 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also @WardF I have upgraded my CI system to build netcdf-fortran with and without parallel I/O with netcdf-c 4.6.3 and hdf5-1.10.5. |
My CI system is showing problems with parallel builds and 4.6.1. I will take a look and fix... |
OK, this branch is now all green on my CI system and on travis, and is ready to merge. |
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #157.
Fixes #161.
Fixes #160.
Part of #85.
In this PR I fix two of the three broken parallel tests.
Also continuing to clean up residue of the ancient cfortran.h build, especially in the acinclude.m4 file, which contains a lot of macros we no longer use anywhere, since we no longer do the cfortran build.
Also removed handling for upper-case mod file names. This has been turned off in the build anyway, and the fortran compiler that subjected me to this horror has died and presumably gone to compiler hell. Which just goes to show, the best revenge really is living well.
Also updated release notes, and added link to documentation in the readme.