Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 broken parallel tests, clean out some remaining support for legacy cfortran build and upper-case mod file names #162

Merged
merged 22 commits into from
Mar 20, 2019

Conversation

edhartnett
Copy link
Contributor

@edhartnett edhartnett commented Mar 16, 2019

Part of #157.
Fixes #161.
Fixes #160.
Part of #85.

In this PR I fix two of the three broken parallel tests.

Also continuing to clean up residue of the ancient cfortran.h build, especially in the acinclude.m4 file, which contains a lot of macros we no longer use anywhere, since we no longer do the cfortran build.

Also removed handling for upper-case mod file names. This has been turned off in the build anyway, and the fortran compiler that subjected me to this horror has died and presumably gone to compiler hell. Which just goes to show, the best revenge really is living well.

Also updated release notes, and added link to documentation in the readme.

@edhartnett
Copy link
Contributor Author

Also @WardF I have upgraded my CI system to build netcdf-fortran with and without parallel I/O with netcdf-c 4.6.3 and hdf5-1.10.5.

@edhartnett
Copy link
Contributor Author

My CI system is showing problems with parallel builds and 4.6.1. I will take a look and fix...

@edhartnett
Copy link
Contributor Author

OK, this branch is now all green on my CI system and on travis, and is ready to merge.

@WardF WardF merged commit 0baf6e4 into Unidata:master Mar 20, 2019
@WardF
Copy link
Member

WardF commented Mar 20, 2019

Awesome, thanks!

@WardF WardF self-assigned this Mar 20, 2019
@WardF WardF added this to the 4.5.0 milestone Mar 20, 2019
@edhartnett edhartnett deleted the ejh_fort_par branch March 20, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unworking and unused --enable-dll option F90 uppercase mod code no longer used or necessary
2 participants