fix compile error: NC_CLASSIC_MODEL #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhartnett
reviewed
Jun 25, 2019
| @@ -51,7 +51,9 @@ | |||
| #include "netcdf.h" | |||
|
|
|||
| #ifndef USE_NETCDF4 | |||
| #ifndef NC_CLASSIC_MODEL | |||
There was a problem hiding this comment.
Won't NC_CLASSIC_MODEL always be defined by netcdf.h?
In which case, the definition here should be removed, not placed in an ifdef...
|
I did not check the logics here. By looking at the file name, I assume this is for NetCDF V2, which may not have NC_CLASSIC_MODEL defined. I added that just to be safe. The latest update for that define was by @DennisHeimbigner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two simple fixes