F90 parallel wr2 test: collective writes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `nf90_put_var` writes were done independently, but this is not possible in the current NetCDF4 library, since unlimited dimensions require collective writes. As a result, this test was failing on our system. We have resolved the problem by switing from `nf90_independent` to `nf90_collective` writes, and removing the rank 0 write test, which was blocking the (now collective) `nf90_put_var` call.
|
Note: An issue solved by this was opened at: Unidata/netcdf-c#340. Making a note here for bookkeeping purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
nf90_put_varwrites were done independently, but thisis not possible in the current NetCDF4 library, since unlimited
dimensions require collective writes. As a result, this test was
failing on our system.
We have resolved the problem by switing from
nf90_independenttonf90_collectivewrites, and removing the rank 0 write test, which wasblocking the (now collective)
nf90_put_varcall.