Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upper air data exposure #159

Merged
merged 5 commits into from
Oct 19, 2017
Merged

Upper air data exposure #159

merged 5 commits into from
Oct 19, 2017

Conversation

jrleeman
Copy link
Contributor

  • Add example of upper air request from Wyoming.
  • Add to API docs.

Closes #155

@jrleeman jrleeman added this to the 0.6.1 milestone Oct 10, 2017
@jrleeman
Copy link
Contributor Author

Sphinx doc build failure appears to be related to: sphinx-doc/sphinx#4139

@jrleeman jrleeman force-pushed the Upperair_Example branch 2 times, most recently from 01de5ef to bd9cf06 Compare October 11, 2017 13:56
@dopplershift
Copy link
Member

We need to add pandas to the example requirements.

@dopplershift
Copy link
Member

Actually, since this is probably core functionality for siphon, it should probably go in the base requirements.

dopplershift
dopplershift requested changes Oct 19, 2017
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was unclear. Since I think lots of people are going to use the upper air support, we should probably make pandas a core requirement in setup.py.

@jrleeman
Copy link
Contributor Author

Failure of the doc build appears to be radar data related. We're hitting live data here!?

@dopplershift
Copy link
Member

Yeah, we hit live data in the Siphon examples.

@dopplershift dopplershift merged commit 2508ad3 into Unidata:master Oct 19, 2017
@jrleeman jrleeman deleted the Upperair_Example branch October 19, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jrleeman @dopplershift