BUG: Fix embedded metadata elements #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
previously approved these changes
Feb 24, 2018
siphon/metadata.py
Outdated
| attributes = element.attrib | ||
| has_xlink_title = xlink_title_attr in attributes | ||
| has_xlink_href = xlink_href_attr in attributes | ||
| return (has_xlink_title and has_xlink_href) |
There was a problem hiding this comment.
Cool - fixed.
| cat = TDSCatalog(url) | ||
| md = cat.metadata | ||
| assert 'external_metadata' in md | ||
| assert 'serviceName' in md |
There was a problem hiding this comment.
This is sufficient to prove that it's working?
There was a problem hiding this comment.
If the embedded metadata element is successfully parsed and understood, then the external_metadata keyword will be added to the metadata dict. If the other metadata isn't added (because the embedded metadata element does not have inherited=true, which is currently the case), then the second assert will fail.
Addresses the case where a metadata element pointing to an external metadata document, via xlink, is a child of a parent metadata element. Fixes Unidata#179
lesserwhirls
force-pushed
the
metadata
branch
from
01a6cfa
to
38504ed
Compare
dopplershift
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the case where a metadata element pointing to an external metadata document, via xlink, is a child of a parent metadata element.
Fixes #179