feat: redux migration #6830
feat: redux migration #6830
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: redux-localstorage-simple@2.4.0 |
1 flaky tests on run #13732 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Token explore filter > should filter correctly by dao search term |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
|
||
| persistStore(store) | ||
| // wait for the migration to complete | ||
| await new Promise((resolve) => setTimeout(resolve, 0)) |
There was a problem hiding this comment.
they don't give us an await persistStore i guess
There was a problem hiding this comment.
I think you need a PersistGate (see https://www.npmjs.com/package/redux-persist) or something similar to make sure the state is loaded before the first render.
You may not want a PersistGate, to avoid a slow pageload experience, but it doesn't seem to pick up my previously connected wallet when I reload the page.
|
Can you also add an e2e test that ensures that saved state is being reflected in pageload? |
cypress/support/commands.ts
Outdated
| ...(options?.userState ?? {}), | ||
| }, | ||
| }, | ||
| 'persist:interface' |
There was a problem hiding this comment.
This should be pulled out as a key from ../../src/state/user/reducer if it can be.
just-toby
force-pushed
the
feat/redux-migrations
branch
from
abce139 to
91ec8f3
Compare
Description
introduces a version management system for the redux state - tests for the type of the App State, migrations which run when versions don't match, and an initial migration to move away from the old library.
Linear ticket: https://linear.app/uniswap/issue/WEB-2224/add-redux-migrations-to-the-interface
Relevant docs: https://www.notion.so/Redux-migrations-in-interface-30aca899626a4ac4af7b070f92ce976d
Screen capture
Before Migration
After Migration (updated 8/14 to show IndexedDB)
Test plan
QA (ie manual testing)
redux-localstorage-simpleand ensured my old state was copied overAutomated testing