Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove zora sepolia from testnets #533

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Mar 27, 2024

In the code pipeline, it failed building due to:

Error: Unknown chain id: 999999999
at ID_TO_NETWORK_NAME (/codebuild/output/src3089245944/src/node_modules/@uniswap/smart-order-router/src/util/chains.ts:281:13)
at /codebuild/output/src3089245944/src/bin/stacks/routing-dashboard-stack.ts:113:78
at Array.map ()
at /codebuild/output/src3089245944/src/bin/stacks/routing-dashboard-stack.ts:108:27
at arrayMap (/codebuild/output/src3089245944/src/node_modules/lodash/lodash.js:653:23)
at map (/codebuild/output/src3089245944/src/node_modules/lodash/lodash.js:9622:14)
at Function.flatMap (/codebuild/output/src3089245944/src/node_modules/lodash/lodash.js:9325:26)
at new RoutingDashboardStack (/codebuild/output/src3089245944/src/bin/stacks/routing-dashboard-stack.ts:102:57)
at new RoutingAPIStack (/codebuild/output/src3089245944/src/bin/stacks/routing-api-stack.ts:225:5)
at Object. (/codebuild/output/src3089245944/src/bin/app.ts:297:1)

The reason is because in SOR, ID_TO_NETWORK_NAME doesn't have the ZORA_SEPOLIA listed there. I think the right fix is to remove ZORA_SEPOLIA from the testnets, because SOR has an open PR about supporting ZORA Uniswap/smart-order-router#501

@jsy1218 jsy1218 self-assigned this Mar 27, 2024
@jsy1218 jsy1218 merged commit 6391bd1 into main Mar 27, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/remove-zora-sepolia-from-testnets branch March 27, 2024 20:29
jsy1218 added a commit that referenced this pull request Apr 12, 2024
remove zora sepolia from testnets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants