Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v4-sdk): remove take_settle_pair, use updated actions constants #210

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

snreynolds
Copy link
Member

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@snreynolds snreynolds requested review from jsy1218 and a team as code owners November 28, 2024 02:53
@snreynolds snreynolds requested a review from hensha256 November 28, 2024 02:53
Copy link

graphite-app bot commented Nov 28, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (11/28/24)

1 reviewer was added and 1 assignee was added to this PR based on 's automation.

@@ -17,27 +17,26 @@ export enum Actions {
DECREASE_LIQUIDITY = 0x01,
MINT_POSITION = 0x02,
BURN_POSITION = 0x03,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we should put in placeholder comments about why some numbers are missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants