-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v4-sdk, v3-sdk, v2-sdk): separate esm / cjs builds #226
base: feat/router-sdk-build
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
31b0afe
to
ffb3c74
Compare
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/eslint-config-react-app@7.0.1 |
28e9a62
to
86fa17d
Compare
9f045cc
to
bf27ecf
Compare
86fa17d
to
20a92ad
Compare
bf27ecf
to
afb7c94
Compare
20a92ad
to
1636941
Compare
afb7c94
to
45e391a
Compare
1636941
to
aae747c
Compare
45e391a
to
da7bc1a
Compare
aae747c
to
b9e2acb
Compare
da7bc1a
to
9c858bb
Compare
b9e2acb
to
45c9f65
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
9c858bb
to
88746ce
Compare
45c9f65
to
fca0031
Compare
PR Scope
breaking change to build structure for
v4-sdk
,v3-sdk
,v2-sdk
, andsdk-core
i updated these 4 SDKs in one PR because otherwise the dependencies were conflicting and causing lint failures.
Description
updates the build setup for
v4-sdk
to manually and explicitly create separate cjs and esm builds (plus a types-only version)How Has This Been Tested?
built the sdk locally, then installed the local build result in another project (
universe/apps/web
) and verified that it properly resolved the esm version instead of the cjs versionAre there any breaking changes?
there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update
(Optional) Follow Ups
PRs to follow will do this for many other SDKs