Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete fade rate cron #186

Merged
merged 9 commits into from
Sep 19, 2023
Merged

feat: complete fade rate cron #186

merged 9 commits into from
Sep 19, 2023

Conversation

ConjunctiveNormalForm
Copy link
Member

@ConjunctiveNormalForm ConjunctiveNormalForm commented Sep 18, 2023

Aggregating faded vs. filled quotes across multiple filler addresses by filler entities and store the result to S3 (which I think is more suitable than dynamo)

Also some refactoring of the repositories - main reason is to make it easier for different Redsfhit-base repositories to share a few methods. I did not touch synth-switch just to be extra safe

Copy link
Contributor

@rileydcampbell rileydcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/repositories/base.ts Show resolved Hide resolved
@ConjunctiveNormalForm ConjunctiveNormalForm merged commit 86160e3 into main Sep 19, 2023
@ConjunctiveNormalForm ConjunctiveNormalForm deleted the fade-rate branch September 19, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants