feat: Automated CB based on timestamps, Cron and DB part #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConjunctiveNormalForm
changed the title
zhongeric
approved these changes
Jan 5, 2024
| newFades = getFillersNewFades(FADES_ROWS, ADDRESS_TO_FILLER, FILLER_TIMESTAMPS, logger); | ||
| }); | ||
|
|
||
| describe('getFillersNewFades', () => { | ||
| it('takes into account multiple filler addresses of the same filler', () => { |
There was a problem hiding this comment.
this test name seems outdated?
rileydcampbell
approved these changes
Jan 9, 2024
that's right, although I think the main goal of the design is to fully automate things |
codyborn
reviewed
Apr 15, 2024
| @@ -56,14 +58,15 @@ export class FadesRepository extends BaseRedshiftRepository { | |||
| } | |||
|
|
|||
| const CREATE_VIEW_SQL = ` | |||
| CREATE OR REPLACE VIEW rfqOrdersTimestamp | |||
| CREATE OR REPLACE VIEW latestRfqs | |||
There was a problem hiding this comment.
This gets the latest 20 RFQs for each filler right? The limit of 1k would prevent us from going over 50 fillers. Is this 50 filler limit expected for the foreseeable future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates a
TimestampDynamo table that tracks filler hash, lastCheckedPostTimestamp (last time the row is updated), and the timestamp that each filler should be blocked until.The fade-rate cron job now calculates related timestamps based on recent order data from Redshift and
Timestamptable