This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a gas test to check which is cheaper between sending the WETH to the Pair at the time you wrap, or in the V2 payment. Transferring at the time of V2 function is cheapest.
You cannot wrap WETH into a specified recipient address so in either scenario it always has to go
the only change is when the weth is sent to the pair, and this is the cheapest.
I think this is because transferring the WETH at the time of wrapping increases the number of non-0 calldata bytes dramatically.