This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Safe mode #162
Merged
Safe mode #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I like this approach.
Although, could add it to swapRouter.ts/swapRouterConfig that way safeMode applies to all trades (NFT included) not just uniswap trades, but this is fine too 🤷
but if we're finding safeMode needs to be applied to other types of trades down the line, might be worth abstracting this out to swapRouter as per above --^
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.