feat: use native gas snapshots #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
approved these changes
Oct 24, 2024
|
This change appears to have broken the build |
Actually it might have been #905, but it's hard to know for sure since the build before that was cancelled. |
Going to track this in a separate issue. While some of these cancellations are timeouts, they mask actual test failures. |
wjmelements
reviewed
Oct 24, 2024
| "ERC6909Claims transfer": "51756", | ||
| "ERC6909Claims transferFrom as operator": "54437", | ||
| "ERC6909Claims transferFrom with approval": "59939", | ||
| "ERC6909Claims transferFrom with infinite approval": "56770" |
There was a problem hiding this comment.
I like that the snapshots are now grouped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes