Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some posm tests #194

Merged
merged 21 commits into from
Jul 31, 2024
Merged

some posm tests #194

merged 21 commits into from
Jul 31, 2024

Conversation

saucepoint
Copy link
Collaborator

Related Issue

Cherry-picked commits to replace #164

Description of changes

  • restored commented-out tests
  • added ERC721 transfer tests for "mint, transfer, and __" flows
  • added "rebalance" (burn & mint) test

Note: left out 6909 tests as we're still deciding how to support it..

@saucepoint saucepoint added the posm position manager label Jul 24, 2024
@saucepoint saucepoint requested a review from snreynolds July 24, 2024 19:22
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love these tests!! just a few comments

test/position-managers/Execute.t.sol Outdated Show resolved Hide resolved
test/position-managers/Execute.t.sol Outdated Show resolved Hide resolved
test/position-managers/Execute.t.sol Show resolved Hide resolved
test/position-managers/FeeCollection.t.sol Show resolved Hide resolved
test/position-managers/FeeCollection.t.sol Outdated Show resolved Hide resolved
test/position-managers/FeeCollection.t.sol Outdated Show resolved Hide resolved
test/position-managers/FeeCollection.t.sol Outdated Show resolved Hide resolved
test/position-managers/FeeCollection.t.sol Show resolved Hide resolved
test/position-managers/PositionManager.t.sol Outdated Show resolved Hide resolved
test/position-managers/PositionManager.t.sol Outdated Show resolved Hide resolved
@saucepoint saucepoint requested a review from snreynolds July 27, 2024 23:33
@saucepoint saucepoint merged commit 463d030 into main Jul 31, 2024
3 checks passed
@saucepoint saucepoint deleted the posm-tests-fix branch July 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
posm position manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants