Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFTP notifications have wrong icons #533

Closed
tyuldashev opened this issue Nov 10, 2022 · 0 comments · Fixed by #537
Closed

SFTP notifications have wrong icons #533

tyuldashev opened this issue Nov 10, 2022 · 0 comments · Fixed by #537
Assignees
@alexey-utkin
Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin

Comments

@tyuldashev
Copy link
Collaborator

Description
Messages about creation of sftp config file and copying project to the server has warning icons while should be info ones

To Reproduce
Steps to reproduce the behavior:

  1. Complete 'UTBot: Quick setup wizards'

Actual behavior
After server configuration if everything completed successfully then couple notifications shown, both have orange triangle as in icons
image

Expected behavior
They have 'info' icons - blue circles as on image below:
image

Additional context
I also think that exclamation sign at the end of these sentences is not necessary.
Probably there are other info messages from SFTP configuration which are also have wrong icons.
@tyuldashev tyuldashev added the bug Something isn't working label Nov 10, 2022
@tyuldashev tyuldashev moved this to Todo in UTBot C/C++ Nov 10, 2022
@ladisgin ladisgin added the vscode-plugin Issue related to VScode plugin label Nov 11, 2022
alexey-utkin added a commit that referenced this issue Nov 14, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528
566d633 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)

Signed-off-by: Alexey Utkin <alexey.utkin@gmail.com>
@alexey-utkin alexey-utkin mentioned this issue Nov 14, 2022
Merged
@alexey-utkin alexey-utkin linked a pull request Nov 14, 2022 that will close this issue
Fixes for #533, #530, #529 (partially), #528 #537
Merged
alexey-utkin added a commit that referenced this issue Nov 15, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528 PR(#537)
59b658f 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
Repository owner moved this from Todo to Done in UTBot C/C++ Nov 15, 2022
@tyuldashev tyuldashev added the verified Bug fix is verified label Nov 15, 2022
Lana243 pushed a commit that referenced this issue Nov 21, 2022
@alexey-utkin @Lana243
Fixes for #533, #530, #529 (partially), #528 PR(#537)
c0569df 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-utkin alexey-utkin

Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin
Projects
UTBot C/C++
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for #533, #530, #529 (partially), #528 UnitTestBot/UTBotCpp
3 participants
@alexey-utkin @tyuldashev @ladisgin