-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont fail error suites #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some documentation about this PR. How does the behavior of running error test will change after this PR?
I would recommend to add this information to wiki or to the description of this PR and also comment new entities like ErrorMode and ErrorType in code.
Do not forget to squash commits before merge.
enum ErrorMode { | ||
FAILING = 0; | ||
PASSING_IN_TARGET_ONLY = 1; | ||
PASSING = 2; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some docs about error mode? Probably, comments or doc at wiki?
enum ErrorType { | ||
NO_ERROR, | ||
ASSERTION_FAILURE, | ||
EXCEPTION_THROWN | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some docs about error mode? Probably, comments or doc at wiki?
737185e
to
cc4ee35
Compare
Before all generated error tests should be fail than run.
In this PR adds the ability to choose whether the test will fail or pass.
This use
EXPECT_ANY_THROW
andASSERT_DEATH
gtest macrosAdd VSCode setting description at wiki