Fix target selection for files and lines (closes #557) #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Lana243
force-pushed
the
Lana243/fix-target-selection
branch
4 times, most recently
from
c9c214c to
63c9039
Compare
Lana243
force-pushed
the
Lana243/fix-target-selection
branch
from
1699202 to
5f9cc54
Compare
Lana243
force-pushed
the
Lana243/fix-target-selection
branch
from
5f9cc54 to
0584611
Compare
ladisgin
reviewed
Dec 13, 2022
| @@ -19,7 +19,7 @@ TargetBuildDatabase::TargetBuildDatabase(BuildDatabase *baseBuildDatabase, const | |||
| } | |||
| } | |||
|
|
|||
| isAutoTarget = target == GrpcUtils::UTBOT_AUTO_TARGET_PATH; | |||
There was a problem hiding this comment.
You don't have any other assignments
There was a problem hiding this comment.
This check always fails, so I just initialized the value of this flag by false.
I guess this flag should be fixed in another PR as it involves another fixes.
Lana243
changed the title
ladisgin
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test are generating for file, function, line, assertion, class or predicate and automatic target is chosen, UTBot selects target that contains the source file