Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointers alignment #34

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Pointers alignment #34

merged 1 commit into from
Sep 6, 2022

Conversation

S1eGa
Copy link
Collaborator

@S1eGa S1eGa commented Aug 31, 2022 •
edited
Loading

Summary:

Checklist:

  • The PR addresses a single issue. If it can be divided into multiple independent PRs, please do so.
  • The PR is divided into a logical sequence of commits OR a single commit is sufficient.
  • There are no unnecessary commits (e.g. commits fixing issues in a previous commit in the same PR).
  • Each commit has a meaningful message documenting what it does.
  • All messages added to the codebase, all comments, as well as commit messages are spellchecked.
  • The code is commented OR not applicable/necessary.
  • The patch is formatted via clang-format OR not applicable (if explicitly overridden leave unchecked and explain).
  • There are test cases for the code you added or modified OR no such test cases are required.

@S1eGa S1eGa force-pushed the getN1ght/pointers-alignment branch 7 times, most recently from b136bee to 1c9df2c Compare September 2, 2022 15:54
@S1eGa S1eGa requested review from misonijnik and ladisgin and removed request for misonijnik September 2, 2022 18:04
@S1eGa S1eGa added the enhancement New feature or request label Sep 5, 2022
@S1eGa
Copy link
Collaborator Author

S1eGa commented Sep 5, 2022

This PR should be approved after this issue.

@S1eGa
Added constaints for pointers: for alignment and size of underlying o…
92a5039 
…bjects. Fixed type creation for C++ types, fixed tests for types and added for alignment.
@S1eGa S1eGa force-pushed the getN1ght/pointers-alignment branch from 1c9df2c to 92a5039 Compare September 6, 2022 13:23
@S1eGa S1eGa requested a review from ladisgin September 6, 2022 15:15
@S1eGa S1eGa merged commit 5bc0312 into utbot-main Sep 6, 2022
@S1eGa S1eGa mentioned this pull request Sep 6, 2022
Closed
@sava-cska sava-cska deleted the getN1ght/pointers-alignment branch September 14, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladisgin ladisgin ladisgin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S1eGa @ladisgin