Add windowsHide option to allow Windows popup from pm2 process file

[natcl]

Please always submit pull requests on the development branch.

Q	A
Bug fix?	yes
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#3425
License	MIT
Doc PR	https://github.com/pm2-hive/pm2-hive.github.io/pulls

[natcl]

This build is currently failing with the error below, it doesn't pass the "Call PM2 inside PM2" test and I'm not sure why, complains that windowsHide is not a boolean even though I check if it's undefined and set it to to true explicitly. Any tips ? Thanks !

  Call PM2 inside PM2
[2018-02-14 23:57:05] PM2 log: Launching in no daemon mode
[2018-02-14 23:57:05] PM2 log: Starting execution sequence in -fork mode- for app name:start_inside id:0
[2018-02-14 23:57:05] PM2 log: App name:start_inside id:0 online
[2018-02-14 23:57:06] PM2 log: Starting execution sequence in -fork mode- for app name:echo id:1
[2018-02-14 23:57:06] PM2 error: Trace: TypeError: "windowsHide" must be a boolean
    at normalizeSpawnArguments (child_process.js:438:11)
    at exports.spawn (child_process.js:496:38)
    at /home/travis/build/Unitech/pm2/lib/God/ForkMode.js:98:20
    at /home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:473:16
    at next (/home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:5315:29)
    at /home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:958:16
    at WriteStream.<anonymous> (/home/travis/build/Unitech/pm2/lib/Utility.js:172:13)
    at emitOne (events.js:116:13)
    at WriteStream.emit (events.js:211:7)
    at fs.open (fs.js:2153:10)
    at FSReqWrap.oncomplete (fs.js:135:15)
    at Object.God.logAndGenerateError (/home/travis/build/Unitech/pm2/lib/God/Methods.js:36:15)
    at /home/travis/build/Unitech/pm2/lib/God/ForkMode.js:106:13
    at /home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:473:16
    at next (/home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:5315:29)
    at /home/travis/build/Unitech/pm2/node_modules/async/dist/async.js:958:16
    at WriteStream.<anonymous> (/home/travis/build/Unitech/pm2/lib/Utility.js:172:13)
    at emitOne (events.js:116:13)
    at WriteStream.emit (events.js:211:7)
    at fs.open (fs.js:2153:10)
    at FSReqWrap.oncomplete (fs.js:135:15)

[natcl]

The test also runs successfully when I run it from my computer.

[vmarchaud]

I'm not sure why you want it to be configurable since its by default at true ?

[natcl]

Because we use it to launch GUI apps so we need to be able to set the setting to false.

[vmarchaud]

Okay i see, i through that it only hide the console window that spawn before the process, it make sense.

[wallet77]

Maybe we should do something like
windowsHide: pm2_env.windowsHide || true

Just in case variable is undefined, it's probably why tests are failing.

[natcl]

windowsHide: pm2_env.windowsHide || true wouldn't work though because false || true equals true so it will never be false (which is the goal).
I did try adding the following however to ensure that windowsHide is not undefined but it still failed the build test in travis (but succeeded on my machine):

var windowsHide = true;
if (pm2_env.windowsHide != undefined) {
    windowsHide = pm2_env.windowsHide
}

[wallet77]

Check undefined is not enough I think, pm2_env.windowsHide can be null, or written as a string "false".
Maybe we should check if variable is a boolean, like so :
typeof(pm2_env.windowHide) === "boolean"

[natcl]

Will test that now ! thanks !

[natcl]

The fix worked but the tests failed for node4 although it doesn't seem related to those changes, is it possible it's a build error ?

[wallet77]

Yes sometimes tests failed on node4. I will rerun the job.

[natcl]

Thanks !

[natcl]

Thanks guys !