Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop-exit-codes #5330

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

Lazyuki
Copy link
Contributor

@Lazyuki Lazyuki commented Mar 18, 2022

Q A
Bug fix? yes (adding a missing feature mentioned in the docs)
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5208
License MIT
Doc PR pm2-hive/pm2-hive.github.io#218 (already added)

This feature stop-exit-codes was first introduced by @jack1142 in the PR #5048 along with the documentation change PR pm2-hive/pm2-hive.github.io#218. However for some reason, only the documentation PR was merged without the actual code and now the live documentation website lists a feature that doesn't actually exist. This of course resulted in this issue #5208 being created.

This PR is continued from jack's PR and adds a few tests. Someone else already made an attempt in #5241 but seems like it was closed without any reason.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2022

CLA assistant check
All committers have signed the CLA.

@jrtg
Copy link

jrtg commented Apr 19, 2022

Would love to see this merged please, will help us out a lot 👍

@dperolio
Copy link

dperolio commented Apr 30, 2022

Yes please. EDIT: I manually changed these files to match the PR, but it still doesn't seem to be working for me. :(

@internpoon
Copy link

Can this be merged please ?

@negreanucalin
Copy link

This feature should be merged, could somebody provide feedback so that it can move forward?

@TotalLag
Copy link

TotalLag commented Nov 6, 2022

@Unitech any guidance here?

@bramvbilsen
Copy link

This is already mentioned in the docs, but the feature itself does not seem to exist yet.
I think this should be removed from the docs until this gets merged.

@smashah
Copy link

smashah commented Dec 29, 2022

In docs, passes tests but not merged?

Considering the fast-pace of Node ecosystem in general, I think this project can do with a bias towards shipping and letting the community deal with potential regressions (that too solved with a bias towards shipping).

Please merge this so the featureset is in-line with current documentation, please. It has been 7 months already.

Thanks

@dreadkopp
Copy link

dreadkopp commented Feb 4, 2023

feature is mentioned in docs since 2021, this pull request / patch / bugfix is nearly a year old...

really like to see this feature (or at least removed from docs...)

I am quite confused about this. considered switchich from supervisor to pm2 but things like leave me wondering how solid this project is

installing the fork this works fine for my usecase for dispatching forked scripts that should not be restarted when run once successful (app booting database migration, initial caching, etc.)

@smashah
Copy link

smashah commented Feb 18, 2023

@Unitech can we bump this PR and get it merged please?

@risserlabs-com
Copy link

Merge this please

@Unitech Unitech merged commit 8a5918a into Unitech:development Apr 9, 2023
@smashah
Copy link

smashah commented May 9, 2023

When is this going to be released?

@luketych
Copy link

luketych commented Aug 30, 2023

Please add support for stop-exit-codes option in the pm2 ecosystem file. Currently it only works in the CLI options.

@Unitech Or advise me on how to do it, and I will try to add it to the codebase.

@gamersindo1223
Copy link

this feature is currently in development:
to install it just use
npm install -g github:Unitech/pm2#development

@smashah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.