-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stop-exit-codes #5330
feat: stop-exit-codes #5330
Conversation
Would love to see this merged please, will help us out a lot 👍 |
Yes please. EDIT: I manually changed these files to match the PR, but it still doesn't seem to be working for me. :( |
Can this be merged please ? |
This feature should be merged, could somebody provide feedback so that it can move forward? |
@Unitech any guidance here? |
This is already mentioned in the docs, but the feature itself does not seem to exist yet. |
In docs, passes tests but not merged? Considering the fast-pace of Node ecosystem in general, I think this project can do with a bias towards shipping and letting the community deal with potential regressions (that too solved with a bias towards shipping). Please merge this so the featureset is in-line with current documentation, please. It has been 7 months already. Thanks |
feature is mentioned in docs since 2021, this pull request / patch / bugfix is nearly a year old... really like to see this feature (or at least removed from docs...) I am quite confused about this. considered switchich from supervisor to pm2 but things like leave me wondering how solid this project is installing the fork this works fine for my usecase for dispatching forked scripts that should not be restarted when run once successful (app booting database migration, initial caching, etc.) |
@Unitech can we bump this PR and get it merged please? |
Merge this please |
When is this going to be released? |
Please add support for stop-exit-codes option in the pm2 ecosystem file. Currently it only works in the CLI options. @Unitech Or advise me on how to do it, and I will try to add it to the codebase. |
this feature is currently in development: |
This feature
stop-exit-codes
was first introduced by @jack1142 in the PR #5048 along with the documentation change PR pm2-hive/pm2-hive.github.io#218. However for some reason, only the documentation PR was merged without the actual code and now the live documentation website lists a feature that doesn't actually exist. This of course resulted in this issue #5208 being created.This PR is continued from jack's PR and adds a few tests. Someone else already made an attempt in #5241 but seems like it was closed without any reason.