Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: collection visibility #183

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix: collection visibility #183

merged 1 commit into from
Apr 11, 2022

Conversation

seandillon92
Copy link
Contributor

Visibility
Full credit to @schinkowski for this solution.
Visibility now takes Collection visibility into account

@seandillon92 seandillon92 requested a review from sindharta April 8, 2022 15:51
sindharta
sindharta approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@sindharta sindharta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we'll have performance problems in complex scenes, but I am approving this for now

@sindharta sindharta merged commit 81314ad into dev Apr 11, 2022
@sindharta sindharta deleted the collection-visibility branch April 11, 2022 02:20
@sindharta sindharta mentioned this pull request Apr 11, 2022
Open
@bitinn
Copy link

bitinn commented Apr 11, 2022

OMG it is happening, thx all involved, obviously excited for potential 2-way sync too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindharta sindharta sindharta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seandillon92 @bitinn @sindharta