Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compile error with generic NetworkBehaviour singletons #2603

Merged
merged 4 commits into from
Jul 18, 2023
Merged

fix: compile error with generic NetworkBehaviour singletons #2603

merged 4 commits into from
Jul 18, 2023

Conversation

ShadauxCat
Copy link
Collaborator

fixes #2592

Changelog

  • Fixed: Fixed an ILPP compile error when creating a generic NetworkBehaviour singleton with a static T instance.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@ShadauxCat ShadauxCat requested a review from a team as a code owner June 29, 2023 19:40
emgamedev-unity3d
emgamedev-unity3d approved these changes Jun 30, 2023
View reviewed changes
Copy link

@emgamedev-unity3d emgamedev-unity3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoelStephensUnity NoelStephensUnity mentioned this pull request Jul 5, 2023
Closed
@PitouGames PitouGames mentioned this pull request Jul 6, 2023
Closed
NoelStephensUnity
NoelStephensUnity approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Kitty!

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 18, 2023 14:35
@NoelStephensUnity NoelStephensUnity merged commit 72d6102 into develop Jul 18, 2023
1 check passed
@NoelStephensUnity NoelStephensUnity deleted the fix/template_singleton_compile_error branch July 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgamedev-unity3d emgamedev-unity3d emgamedev-unity3d approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unusual Error in version 1.5.1
3 participants
@ShadauxCat @emgamedev-unity3d @NoelStephensUnity