fix: RemoveOwnership not locally notifying server that it gained ownership [MTT-6377] [MTT-6937][MTT-6936] #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a few ownership related issues specifically noticed when using an owner authoritative NetworkTransform and ownership is removed. This also assures NetworkVariables will be updated if ownership is removed just like they are when ownership is changed. This also fixes an issue where NetworkManager's ShutdownInProgress was not true upon the application quitting which was causing an exception to occur within NetworkVariableBase under specific conditions.
ShadauxCat
reviewed
Jul 12, 2023
…ttps://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/remove-ownership-server-notification-MTT-6377
NoelStephensUnity
changed the title
NoelStephensUnity
changed the title
ShadauxCat
approved these changes
Jul 14, 2023
NoelStephensUnity
deleted the
fix/remove-ownership-server-notification-MTT-6377
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a few ownership related issues specifically noticed when using an owner authoritative NetworkTransform and ownership is removed.
This also assures NetworkVariables will be updated if ownership is removed just like they are when ownership is changed.
This also fixes an issue where NetworkManager's ShutdownInProgress was not true upon the application quitting which was causing an exception to occur within NetworkVariableBase under specific conditions.
MTT-6936
MTT-6937
MTT-6377
fix: #2563
fix: #2606
fix: #2511
fix: #2629
Changelog
Testing and Documentation