Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add null check in TrySetParent #2625

Merged
merged 4 commits into from
Jul 20, 2023
Merged

fix: Add null check in TrySetParent #2625

merged 4 commits into from
Jul 20, 2023

Conversation

ShadauxCat
Copy link
Collaborator

fixes #2621

Changelog

  • Fixed: Fixed a crash when calling TrySetParent with a null Transform

Testing and Documentation

  • Includes integration tests.

@ShadauxCat ShadauxCat requested a review from a team as a code owner July 13, 2023 17:26
NoelStephensUnity
NoelStephensUnity approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the change log, the rest looks good to me!

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) July 19, 2023 23:33
@NoelStephensUnity NoelStephensUnity merged commit 7e4efe1 into develop Jul 20, 2023
1 check passed
@NoelStephensUnity NoelStephensUnity deleted the fix/null_check_in_TrySetParent branch July 20, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting null as parent using TrySetParent throws a null reference exception
2 participants
@ShadauxCat @NoelStephensUnity