Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

MLFlow: Lookup client_id and host_id from Kubernetes env variable #133

Merged
merged 13 commits into from
Feb 1, 2021
Merged

MLFlow: Lookup client_id and host_id from Kubernetes env variable #133

merged 13 commits into from
Feb 1, 2021

Conversation

86sanj
Copy link
Contributor

@86sanj 86sanj commented Jan 5, 2021 •
edited
Loading

Peer Review Information

This commit includes following changes:

  1. Lookup mlflow client_id and host_id from Kubernetes env variable, if both are configured in config YAML then override with YAML values.
  2. Updated pipelines.py with env variable lookup, compiled pipelines
  3. Unit test case

Kubeflow run_id: train_on_real_world_dataset-test 5

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@86sanj 86sanj requested review from adason and Saurav-D January 5, 2021 20:54
@86sanj 86sanj force-pushed the mlflow-login-config branch from e7fbd46 to e8c1e8b Compare January 5, 2021 21:09
adason
adason reviewed Jan 20, 2021
View reviewed changes
datasetinsights/io/tracker/mlflow.py Outdated Show resolved Hide resolved
datasetinsights/io/tracker/factory.py Outdated Show resolved Hide resolved
datasetinsights/io/tracker/mlflow.py Outdated Show resolved Hide resolved
datasetinsights/io/tracker/mlflow.py Show resolved Hide resolved
@86sanj 86sanj requested a review from BlairLee January 21, 2021 19:45
adason
adason previously approved these changes Feb 1, 2021
View reviewed changes
@adason
Copy link
Contributor

adason commented Feb 1, 2021

@Saurav-D Can you also review this PR?

@adason adason self-requested a review February 1, 2021 18:48
Saurav-D
Saurav-D previously approved these changes Feb 1, 2021
View reviewed changes
@86sanj 86sanj dismissed stale reviews from Saurav-D and adason via b00fcec February 1, 2021 20:28
@86sanj 86sanj merged commit d67e9ca into master Feb 1, 2021
@86sanj 86sanj deleted the mlflow-login-config branch February 1, 2021 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Saurav-D Saurav-D Saurav-D approved these changes

@BlairLee BlairLee Awaiting requested review from BlairLee

@adason adason Awaiting requested review from adason

Assignees

@Saurav-D Saurav-D

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@86sanj @adason @Saurav-D