Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ServerInfo #28

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Extend ServerInfo #28

merged 5 commits into from
Oct 16, 2019

Conversation

mightyBroccoli
Copy link
Contributor

Based on: @AnthoDingo pull request #20

AnthoDingo and others added 5 commits October 16, 2019 00:08
@AnthoDingo @mightyBroccoli
Extend Server json struct
495d491 
Add more value in Server struct
@AnthoDingo @mightyBroccoli
Moving structure
6d35c77 
Moving to ServerConnectionInfo values from Server
@AnthoDingo @mightyBroccoli
Fix missing return
2cabd50
@mightyBroccoli
wording and tests
f1554e4 
* change wording to better represent the raw values
+ add new entries to server_cmd_test.go
@mightyBroccoli
mockserver and cleanup
77a5e4f 
* run gofmt -s to please travis
+ add values to mockserver file
@stevenh stevenh merged commit e748530 into Unity-Technologies:master Oct 16, 2019
@stevenh stevenh mentioned this pull request Oct 16, 2019
Closed
@mightyBroccoli mightyBroccoli deleted the extended_info branch October 16, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mightyBroccoli @stevenh @AnthoDingo