Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle None action outputs #2988

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

chriselion
Copy link
Contributor

This started happening in #2913, but only shows up in the WallJump scene. It happens eventually when running the full scene, but happens right away if only 2 of the areas are enabled; we believe it's due to all of the agents only using one of the two brains.

There might be a cleaner fix for this, but we'll merge this today for the release if a better solution doesn't present itself.

@vincentpierre
Copy link
Contributor

I think it is fairly elegant

Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still curious what root cause is (and why the previous action change would affect this at all?) but the fix here looks clean.

@chriselion chriselion merged commit 5dc92f1 into release-0.12.0 Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-0.12.0-null-actions branch November 27, 2019 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants