Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLA-345] float visual observations #3148

Merged
merged 9 commits into from
Jan 7, 2020
Merged

[MLA-345] float visual observations #3148

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4858f42
pass shape to WriteAdapter
Jan 2, 2020
a6290a3
handle floats on python side
Jan 3, 2020
a93c63e
cleanup
Jan 3, 2020
8043904
whitespace
Jan 3, 2020
1bd0d35
rename GetFloatObservationShape, support uncompressed in RenderTextur…
Jan 3, 2020
7f7d98d
numpy float32
Jan 3, 2020
c63cc71
remove unused using
Jan 3, 2020
f41bede
Float sensor and unit test
Jan 4, 2020
9179b08
replace asserts with exceptions, docstrings
Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnitySDK/Assets/ML-Agents/Editor/Tests/Sensor/VectorSensorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static void CompareObservation(ISensor sensor, float[] expected)
Assert.AreEqual(fill, output[0]);

WriteAdapter writer = new WriteAdapter();
writer.SetTarget(output, 0);
writer.SetTarget(output, sensor.GetFloatObservationShape(), 0);

// Make sure WriteAdapter didn't touch anything
Assert.AreEqual(fill, output[0]);
Expand Down
22 changes: 13 additions & 9 deletions UnitySDK/Assets/ML-Agents/Editor/Tests/Sensor/WriterAdapterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,26 @@ public void TestWritesToIList()
{
WriteAdapter writer = new WriteAdapter();
var buffer = new[] { 0f, 0f, 0f };
var shape = new[] { 3 };

writer.SetTarget(buffer, 0);
writer.SetTarget(buffer, shape, 0);
// Elementwise writes
writer[0] = 1f;
writer[2] = 2f;
Assert.AreEqual(new[] { 1f, 0f, 2f }, buffer);

// Elementwise writes with offset
writer.SetTarget(buffer, 1);
writer.SetTarget(buffer, shape, 1);
writer[0] = 3f;
Assert.AreEqual(new[] { 1f, 3f, 2f }, buffer);

// AddRange
writer.SetTarget(buffer, 0);
writer.SetTarget(buffer, shape, 0);
writer.AddRange(new [] {4f, 5f});
Assert.AreEqual(new[] { 4f, 5f, 2f }, buffer);

// AddRange with offset
writer.SetTarget(buffer, 1);
writer.SetTarget(buffer, shape, 1);
writer.AddRange(new [] {6f, 7f});
Assert.AreEqual(new[] { 4f, 6f, 7f }, buffer);
}
Expand All @@ -47,12 +48,13 @@ public void TestWritesToTensor()
valueType = TensorProxy.TensorType.FloatingPoint,
data = new Tensor(2, 3)
};
writer.SetTarget(t, 0, 0);
var shape = new[] { 3 };
writer.SetTarget(t, shape, 0, 0);
Assert.AreEqual(0f, t.data[0, 0]);
writer[0] = 1f;
Assert.AreEqual(1f, t.data[0, 0]);

writer.SetTarget(t, 1, 1);
writer.SetTarget(t, shape, 1, 1);
writer[0] = 2f;
writer[1] = 3f;
// [0, 0] shouldn't change
Expand All @@ -67,7 +69,7 @@ public void TestWritesToTensor()
data = new Tensor(2, 3)
};

writer.SetTarget(t, 1, 1);
writer.SetTarget(t, shape, 1, 1);
writer.AddRange(new [] {-1f, -2f});
Assert.AreEqual(0f, t.data[0, 0]);
Assert.AreEqual(0f, t.data[0, 1]);
Expand All @@ -87,11 +89,13 @@ public void TestWritesToTensor3D()
data = new Tensor(2, 2, 2, 3)
};

writer.SetTarget(t, 0, 0);
var shape = new[] { 2, 2, 3 };

writer.SetTarget(t, shape, 0, 0);
writer[1, 0, 1] = 1f;
Assert.AreEqual(1f, t.data[0, 1, 0, 1]);

writer.SetTarget(t, 0, 1);
writer.SetTarget(t, shape, 0, 1);
writer[1, 0, 0] = 2f;
Assert.AreEqual(2f, t.data[0, 1, 0, 1]);
}
Expand Down
Loading