Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dark mode from screenshots #3772

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Removing dark mode from screenshots

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Apr 13, 2020
Copy link

@mmattar mmattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@vincentpierre vincentpierre merged commit 34db9c2 into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-remove-dark-mode branch April 14, 2020 21:06
mmattar pushed a commit that referenced this pull request Apr 15, 2020
commit 9600d0f
Author: Marwan Mattar <marwan@unity3d.com>
Date:   Tue Apr 14 17:45:33 2020 -0700

    Various doc improvements (#3775)

    * Various doc improvements

    For Using-Virtual-Environment.md:
    - Made a note regarding updating setuptools and pip.
    - Changed lists from "-" to "*"

    For Using-Tensorboard.md:
    - Changed the ordered list to use "1."

    For Training-on-Microsoft-Azure-Custom-Instance.md:
    - Deleted as it was not linked anywhere

    For FAQ.md
    - Removed stale issues given upgrade to 2018.3

    For Readme.md
    - Added links for Reward Signals, Self-Play and Profiling Trainers

    For Learning-Environment-Executable.md
    - Changed the ordered list to use "1."

    For Learning-Environment-Examples.md
    - Minor rewording of intro paragraphs

    * consolidating custom instances page in main page

    So we have a single page for Azure.

    Adding warning note for deprecated docs

    * Fixing doc links that are failing CI

commit 34db9c2
Author: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Date:   Tue Apr 14 14:06:16 2020 -0700

    Removing dark mode from screenshots (#3772)

commit 1e164cc
Author: Chris Elion <chris.elion@unity3d.com>
Date:   Tue Apr 14 13:08:18 2020 -0700

    [MLA-488] Fix observations in demonstration drawer (#3771)

    * WIP observation shapes

    * WIP observation shapes

    * fix Observation shape serialization

    * rename field, redo screenshot

    * docstring

    * changelog
mmattar pushed a commit that referenced this pull request Apr 15, 2020
* Improvements to Training-ML-Agents

- Removed duplicate documentation
- Moved CLI descriptions to learn.py
- Reorganized "Training with mlagents-learn" into 5 sub-sections

* fixed formatting errors and incorporated minor feedback

* minor improvement

* Minor formatting.

* fixed run-id references

* Keeping link to use Inference consistent with master

Will update the UIE page in a separate PR.

* Squashed commit of the following:

commit 9600d0f
Author: Marwan Mattar <marwan@unity3d.com>
Date:   Tue Apr 14 17:45:33 2020 -0700

    Various doc improvements (#3775)

    * Various doc improvements

    For Using-Virtual-Environment.md:
    - Made a note regarding updating setuptools and pip.
    - Changed lists from "-" to "*"

    For Using-Tensorboard.md:
    - Changed the ordered list to use "1."

    For Training-on-Microsoft-Azure-Custom-Instance.md:
    - Deleted as it was not linked anywhere

    For FAQ.md
    - Removed stale issues given upgrade to 2018.3

    For Readme.md
    - Added links for Reward Signals, Self-Play and Profiling Trainers

    For Learning-Environment-Executable.md
    - Changed the ordered list to use "1."

    For Learning-Environment-Examples.md
    - Minor rewording of intro paragraphs

    * consolidating custom instances page in main page

    So we have a single page for Azure.

    Adding warning note for deprecated docs

    * Fixing doc links that are failing CI

commit 34db9c2
Author: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Date:   Tue Apr 14 14:06:16 2020 -0700

    Removing dark mode from screenshots (#3772)

commit 1e164cc
Author: Chris Elion <chris.elion@unity3d.com>
Date:   Tue Apr 14 13:08:18 2020 -0700

    [MLA-488] Fix observations in demonstration drawer (#3771)

    * WIP observation shapes

    * WIP observation shapes

    * fix Observation shape serialization

    * rename field, redo screenshot

    * docstring

    * changelog

* Revert "Squashed commit of the following:"

This reverts commit 819e8d5.

* Removing debugging section.

* Prettier formatting

* Fixing Prettier oddity
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants